[PATCH] api-allocation-growing.txt: encourage better variable naming

2013-01-06 Thread Adam Spiers
The documentation for the ALLOC_GROW API implicitly encouraged developers to use ary as the variable name for the array which is dynamically grown. However ary is an unusual abbreviation hardly used anywhere else in the source tree, and it is also better to name variables based on their contents

Re: [PATCH] api-allocation-growing.txt: encourage better variable naming

2013-01-06 Thread Junio C Hamano
Adam Spiers g...@adamspiers.org writes: The documentation for the ALLOC_GROW API implicitly encouraged developers to use ary as the variable name for the array which is dynamically grown. However ary is an unusual abbreviation hardly used anywhere else in the source tree, and it is also

Re: [PATCH] api-allocation-growing.txt: encourage better variable naming

2013-01-06 Thread Adam Spiers
On Sun, Jan 06, 2013 at 12:29:33PM -0800, Junio C Hamano wrote: Adam Spiers g...@adamspiers.org writes: The documentation for the ALLOC_GROW API implicitly encouraged developers to use ary as the variable name for the array which is dynamically grown. However ary is an unusual

Re: [PATCH] api-allocation-growing.txt: encourage better variable naming

2013-01-06 Thread Junio C Hamano
Adam Spiers g...@adamspiers.org writes: Sounds good. To follow not type but contents, a further rewrite with s/array/item/ is even better, no? I agree. Thanks for a quick response; let's do this then. -- 8 -- From: Adam Spiers g...@adamspiers.org The documentation for the ALLOC_GROW API