Re: [PATCH] cleanup argument passing in submodule status command

2012-07-29 Thread Junio C Hamano
Heiko Voigt hvo...@hvoigt.net writes: Note: This is a code cleanup and does not fix any bugs. As a side effect the variables containing the parsed flags to git submodule status are passed down recursively. So everything was already behaving as expected. If that is the case, shouldn't we stop

Re: [PATCH] cleanup argument passing in submodule status command

2012-07-29 Thread Jens Lehmann
Am 29.07.2012 08:22, schrieb Junio C Hamano: Heiko Voigt hvo...@hvoigt.net writes: Note: This is a code cleanup and does not fix any bugs. As a side effect the variables containing the parsed flags to git submodule status are passed down recursively. So everything was already behaving as

Re: [PATCH] cleanup argument passing in submodule status command

2012-07-29 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: I tried today. Before this change no arguments got passed down and afterwards they are (but just the arguments, no submodule paths were passed on in either case; which is what Kevin fixed in the commit Heiko referenced). Three arguments are allowed for

[PATCH] cleanup argument passing in submodule status command

2012-07-28 Thread Heiko Voigt
In commit 98dbe63 the variable $orig_args was renamed to $orig_flags. One location in cmd_status() was missed. Note: This is a code cleanup and does not fix any bugs. As a side effect the variables containing the parsed flags to git submodule status are passed down recursively. So everything was