Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-03 Thread Jens Lindström
On Mon, Jul 1, 2013 at 6:20 PM, Junio C Hamano gits...@pobox.com wrote: I am not sure if we should care that deeply about them in the first place. Fine by me; I don't really have a strong opinion on the matter. Besides, I think you can make a hardlink to a file that you cannot read. Not

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-03 Thread Junio C Hamano
Jens Lindström j...@opera.com writes: On Mon, Jul 1, 2013 at 6:20 PM, Junio C Hamano gits...@pobox.com wrote: I am not sure if we should care that deeply about them in the first place. Fine by me; I don't really have a strong opinion on the matter. Besides, I think you can make a hardlink

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-01 Thread Jens Lindström
On Fri, Jun 28, 2013 at 8:38 PM, Junio C Hamano gits...@pobox.com wrote: The pack-*.keep files are temporary, and serve no purpose in the clone. They are not temporary, actually. A user can deliberatey create a keep marker after packing with a good set of parameters, so that the resulting

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-01 Thread Junio C Hamano
Jens Lindström j...@opera.com writes: On Fri, Jun 28, 2013 at 8:38 PM, Junio C Hamano gits...@pobox.com wrote: The pack-*.keep files are temporary, and serve no purpose in the clone. They are not temporary, actually. A user can deliberatey create a keep marker after packing with a good set

[PATCH] clone: Skip pack-*.keep files when cloning locally

2013-06-28 Thread Jens Lindstrom
The pack-*.keep files are temporary, and serve no purpose in the clone. They would probably also never be deleted from the clone if copied, since the process that created them only expects to have to delete them from the original repository. Worse, though, they are created with access bits 0600,

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-06-28 Thread Junio C Hamano
Jens Lindstrom j...@opera.com writes: Hmph. I am of two minds here. The pack-*.keep files are temporary, and serve no purpose in the clone. They are not temporary, actually. A user can deliberatey create a keep marker after packing with a good set of parameters, so that the resulting pack

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-06-28 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: I am perfectly fine with a change that allows a local clone to skip and not error out when such a keep marker cannot be copied, I do not know if it is a good idea to unconditionally skip and not even attempt to copy it. That is, something like this,