Re: [PATCH] clone: tighten "local paths with colons" check a bit

2013-09-28 Thread Torsten Bögershausen
On 2013-09-27 23.56, Jonathan Nieder wrote: > Nguyễn Thái Ngọc Duy wrote: > >> commit 6000334 (clone: allow cloning local paths with colons in them - >> 2013-05-04) is added to make it possible to specify a path that has >> colons in it without file://, e.g. ../foo:bar/somewhere. But the check >>

Re: [PATCH] clone: tighten "local paths with colons" check a bit

2013-09-27 Thread Jonathan Nieder
Nguyễn Thái Ngọc Duy wrote: > commit 6000334 (clone: allow cloning local paths with colons in them - > 2013-05-04) is added to make it possible to specify a path that has > colons in it without file://, e.g. ../foo:bar/somewhere. But the check > is a bit loose. [...] > Make sure we only check so w

Re: [PATCH] clone: tighten "local paths with colons" check a bit

2013-09-27 Thread Jeff King
On Fri, Sep 27, 2013 at 08:48:13PM +0700, Nguyen Thai Ngoc Duy wrote: > --- > I wanted to add a test then realized there were no ssh tests in the > test suite. So laziness won :p There is one in t5602, but it's not very reusable. How about squashing in the patch below, which does a basic ssh-wo

[PATCH] clone: tighten "local paths with colons" check a bit

2013-09-27 Thread Nguyễn Thái Ngọc Duy
commit 6000334 (clone: allow cloning local paths with colons in them - 2013-05-04) is added to make it possible to specify a path that has colons in it without file://, e.g. ../foo:bar/somewhere. But the check is a bit loose. Consider the url '[foo]:bar', the '[]' unwrapping code will turn the str