Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Junio C Hamano
John Keeping writes: > On Fri, Jun 14, 2013 at 06:45:19PM +0530, Ramkumar Ramachandra wrote: >> John Keeping wrote: >> > I don't think this is the correct behaviour. I can think of cases where >> > I would want to output multiple things into the same directory. >> >> format.cleanOutputDirectory

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Ramkumar Ramachandra
Fredrik Gustafsson wrote: > git format-patch always creates a new directory like: > .git/outgoing/[patchname]... > and possible runs a custom command afterwards. Like cd to the patch > directory, open the cover-letter in your editor etc. > > git send-email without patches specified gives you a list

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Junio C Hamano
John Keeping writes: > On Fri, Jun 14, 2013 at 06:13:33PM +0530, Ramkumar Ramachandra wrote: >> The following command >> >> $ git format-patch -o outgoing master >> >> does not ensure that the output-directory outgoing doesn't already >> exist. As a result, it's possible for patches from two

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Ramkumar Ramachandra
SZEDER Gábor wrote: > _git_fp () { _git_format_patch ; } Good stopgap, thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread SZEDER Gábor
On Fri, Jun 14, 2013 at 07:04:18PM +0530, Ramkumar Ramachandra wrote: > My main itch is that completion doesn't work with my fp: > > alias.fp = !rm -rf outgoing && git format-patch -M -C -o outgoing Why not define your custom completion function for this alias in your .bashrc? _git_fp () { _

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Fredrik Gustafsson
On Fri, Jun 14, 2013 at 07:04:18PM +0530, Ramkumar Ramachandra wrote: > Fredrik Gustafsson wrote: > > However I think this patch can improve the workflow for experienced > > developers. Can we tweak this in some way to get the best out of both > > worlds? > > The main problem is that output-direct

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Ramkumar Ramachandra
Fredrik Gustafsson wrote: > However I think this patch can improve the workflow for experienced > developers. Can we tweak this in some way to get the best out of both > worlds? The main problem is that output-directory can be an absolute path (like ~, in the extreme case). I'm not sure how to tr

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread John Keeping
On Fri, Jun 14, 2013 at 06:45:19PM +0530, Ramkumar Ramachandra wrote: > John Keeping wrote: > > I don't think this is the correct behaviour. I can think of cases where > > I would want to output multiple things into the same directory. > > format.cleanOutputDirectory = true|false? Maybe, but I w

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Ramkumar Ramachandra
John Keeping wrote: > I don't think this is the correct behaviour. I can think of cases where > I would want to output multiple things into the same directory. format.cleanOutputDirectory = true|false? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to m

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Fredrik Gustafsson
Hi, just some questions about your patch. On Fri, Jun 14, 2013 at 06:13:33PM +0530, Ramkumar Ramachandra wrote: > The following command > > $ git format-patch -o outgoing master > > does not ensure that the output-directory outgoing doesn't already > exist. As a result, it's possible for patc

Re: [PATCH] format-patch: remove existing output-directory

2013-06-14 Thread John Keeping
On Fri, Jun 14, 2013 at 06:13:33PM +0530, Ramkumar Ramachandra wrote: > The following command > > $ git format-patch -o outgoing master > > does not ensure that the output-directory outgoing doesn't already > exist. As a result, it's possible for patches from two different series > to get mixe

[PATCH] format-patch: remove existing output-directory

2013-06-14 Thread Ramkumar Ramachandra
The following command $ git format-patch -o outgoing master does not ensure that the output-directory outgoing doesn't already exist. As a result, it's possible for patches from two different series to get mixed up if the user is not careful. Fix the problem by unconditionally removing the ou