Re: [PATCH] git-gui: bring Wish process to front on Mac

2013-06-07 Thread Stefan Haller
Junio C Hamano wrote: > Stefan (as your name appears in 76bf6ff93e, I am assuming that you > were the OSX-osascript guru in that commit) could you keep an eye on > the list traffic to see if users of latest gitk have issues with > that change, please? Sure, will do. -- Stefan Haller Berlin, G

Re: [PATCH] git-gui: bring Wish process to front on Mac

2013-06-06 Thread Junio C Hamano
Pat Thoyts writes: > Seems fine to me. I can't test this as I have no access to this > platform. Possibly you should run this in a catch statement so it can > ignore any errors and I would tend to use the 'auto_execok' command to > ensure that osascript actually exists. Something like > > set a

Re: [PATCH] git-gui: bring Wish process to front on Mac

2013-06-06 Thread Stefan Haller
Pat Thoyts wrote: > On 6 June 2013 09:17, Stefan Haller wrote: > > +## On Mac, bring the current Wish process window to front > > + > > +if {[tk windowingsystem] eq "aqua"} { > > + exec osascript -e [format { > > + tell application "System Events" > > +

Re: [PATCH] git-gui: bring Wish process to front on Mac

2013-06-06 Thread Pat Thoyts
On 6 June 2013 09:17, Stefan Haller wrote: > On Mac OS X, any application that is started from the Terminal will open > behind all running applications; as a work-around, manually bring ourselves > to the front. (Stolen from gitk, commit 76bf6ff93e.) > > We do this as the very first thing, so that

[PATCH] git-gui: bring Wish process to front on Mac

2013-06-06 Thread Stefan Haller
On Mac OS X, any application that is started from the Terminal will open behind all running applications; as a work-around, manually bring ourselves to the front. (Stolen from gitk, commit 76bf6ff93e.) We do this as the very first thing, so that any message boxes that might pop up during the rest