Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-19 Thread Duy Nguyen
On Mon, Dec 19, 2016 at 9:05 PM, Jeff King wrote: > On Mon, Dec 19, 2016 at 08:53:30PM +0700, Duy Nguyen wrote: > >> >> Your commit message does not make clear if you want this "fatal" to be >> >> grep-able (by scripts) or not. If not, please _() the string. Maybe >> >> this to reduce work for tr

Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-19 Thread Jeff King
On Mon, Dec 19, 2016 at 09:30:09PM +0700, Duy Nguyen wrote: > On Mon, Dec 19, 2016 at 9:05 PM, Jeff King wrote: > > On Mon, Dec 19, 2016 at 08:53:30PM +0700, Duy Nguyen wrote: > > > >> >> Your commit message does not make clear if you want this "fatal" to be > >> >> grep-able (by scripts) or not.

Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-19 Thread Jeff King
On Mon, Dec 19, 2016 at 08:53:30PM +0700, Duy Nguyen wrote: > >> Your commit message does not make clear if you want this "fatal" to be > >> grep-able (by scripts) or not. If not, please _() the string. Maybe > >> this to reduce work for translators > >> > >> /* TRANSLATORS: this is the pre

Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-19 Thread Duy Nguyen
On Mon, Dec 19, 2016 at 8:41 PM, Jeff King wrote: > On Mon, Dec 19, 2016 at 07:07:19PM +0700, Duy Nguyen wrote: > >> On Wed, Dec 14, 2016 at 10:10:10AM -0500, Jeff King wrote: >> > diff --git a/parse-options.c b/parse-options.c >> > index 312a85dbd..4fbe924a5 100644 >> > --- a/parse-options.c >> >

Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-19 Thread Jeff King
On Mon, Dec 19, 2016 at 07:07:19PM +0700, Duy Nguyen wrote: > On Wed, Dec 14, 2016 at 10:10:10AM -0500, Jeff King wrote: > > diff --git a/parse-options.c b/parse-options.c > > index 312a85dbd..4fbe924a5 100644 > > --- a/parse-options.c > > +++ b/parse-options.c > > @@ -661,7 +661,7 @@ void NORETUR

Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-19 Thread Duy Nguyen
On Wed, Dec 14, 2016 at 10:10:10AM -0500, Jeff King wrote: > diff --git a/parse-options.c b/parse-options.c > index 312a85dbd..4fbe924a5 100644 > --- a/parse-options.c > +++ b/parse-options.c > @@ -661,7 +661,7 @@ void NORETURN usage_msg_opt(const char *msg, > const char * const *u

Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-14 Thread Junio C Hamano
Jeff King writes: > Programs may use usage_msg_opt() to print a brief message > followed by the program usage, and then exit. The message > isn't prefixed at all, though, so it doesn't match our usual > error output and is easy to overlook: > > $ git clone 1 2 3 > Too many arguments. > >

[PATCH] parse-options: print "fatal:" before usage_msg_opt()

2016-12-14 Thread Jeff King
Programs may use usage_msg_opt() to print a brief message followed by the program usage, and then exit. The message isn't prefixed at all, though, so it doesn't match our usual error output and is easy to overlook: $ git clone 1 2 3 Too many arguments. usage: git clone [] [--] []