Re: [PATCH] send-email: provide port separately from hostname

2013-07-04 Thread brian m. carlson
On Fri, Jul 05, 2013 at 04:12:19AM +0530, Ramkumar Ramachandra wrote: > Hm, so the problem occurs when you give smtp_host_string() to > Net::SMTP->new() as the first argument. Yes. I created a test program, and Net::SMTP was fine as long as I used Port, but failed when I included the port in the

Re: [PATCH] send-email: provide port separately from hostname

2013-07-04 Thread Ramkumar Ramachandra
brian m. carlson wrote: > diff --git a/git-send-email.perl b/git-send-email.perl > index bd13cc8..ca86a13 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -1199,9 +1199,11 @@ X-Mailer: git-send-email $gitversion > else { > require Net::SMTP

[PATCH] send-email: provide port separately from hostname

2013-07-04 Thread brian m. carlson
From: "brian m. carlson" If the SMTP port is provided as part of the hostname to Net::SMTP, it passes the combined string to the SASL provider; this causes GSSAPI authentication to fail since Kerberos does not want the port information. Instead, pass the port as a separate argument as is done fo