Re: [PATCH 0/4] pre-push hook support

2012-12-29 Thread Junio C Hamano
Aaron Schrab writes: > At 18:01 -0800 28 Dec 2012, Junio C Hamano wrote: >>Will it be "all-or-none", or "I'll allow these but not those"? > > Currently it just uses the exit code to communicate that back, so it's > all-or-none. I think I'll keep that in the updated version as well. Thanks; tha

Re: [PATCH 0/4] pre-push hook support

2012-12-29 Thread Aaron Schrab
At 18:01 -0800 28 Dec 2012, Junio C Hamano wrote: One lesson we learned long time ago while doing hooks is to avoid unbound number of command line arguments and instead feed them from the standard input. I think this should do the same. Good point. I had been trying to keep the interface for

Re: [PATCH 0/4] pre-push hook support

2012-12-28 Thread Junio C Hamano
Aaron Schrab writes: > There have been at least a couple of submissions to add support for a > pre-push hook, which were rejected at least partially because they didn't > provide enough information to a hook script for it to determine what was > to be pushed any better than a separate wrapper aro

[PATCH 0/4] pre-push hook support

2012-12-28 Thread Aaron Schrab
There have been at least a couple of submissions to add support for a pre-push hook, which were rejected at least partially because they didn't provide enough information to a hook script for it to determine what was to be pushed any better than a separate wrapper around the 'git push' command woul