Re: [PATCH 0/6] minor test-hashmap fixes

2018-02-14 Thread Jeff King
On Wed, Feb 14, 2018 at 10:41:35AM -0800, Stefan Beller wrote: > I have lost track of the hashmap improvements lately, but with > such a good test helper, we could reduce the amount of > commented code in hashmap.h and just link to the test helper? > (as an extra step after this series, I thought

Re: [PATCH 0/6] minor test-hashmap fixes

2018-02-14 Thread Stefan Beller
On Wed, Feb 14, 2018 at 10:03 AM, Jeff King wrote: > This series started with me fixing the sizeof() mismatch discussed in > > https://public-inbox.org/git/20180214164628.ga...@sigill.intra.peff.net/ > > but I found a number of minor irritations. Most of them are cosmetic in >

[PATCH 0/6] minor test-hashmap fixes

2018-02-14 Thread Jeff King
This series started with me fixing the sizeof() mismatch discussed in https://public-inbox.org/git/20180214164628.ga...@sigill.intra.peff.net/ but I found a number of minor irritations. Most of them are cosmetic in practice, but I think it's important for test-helper code like this to model