On Mon, Aug 01, 2016 at 01:32:49PM -0700, Junio C Hamano wrote:
> Josh Triplett writes:
>
> > +static char *from;
> > static const char *signature = git_version_string;
> > static const char *signature_file;
> > static int config_cover_letter;
> > @@ -807,6 +808,17 @@ static int git_format_con
Josh Triplett writes:
> +static char *from;
> static const char *signature = git_version_string;
> static const char *signature_file;
> static int config_cover_letter;
> @@ -807,6 +808,17 @@ static int git_format_config(const char *var, const char
> *value, void *cb)
> base_auto
On Sat, Jul 30, 2016 at 11:12:46AM -0700, Josh Triplett wrote:
> > These tests follow a different style from the "--from" tests later in
> > the script (and your second patch does follow it, and puts its test
> > close there). Any reason not to have all of the "from" tests together,
> > and using
On Sat, Jul 30, 2016 at 11:40:34AM -0400, Jeff King wrote:
> On Sat, Jul 30, 2016 at 02:41:56AM -0700, Josh Triplett wrote:
>
> > @@ -807,6 +808,17 @@ static int git_format_config(const char *var, const
> > char *value, void *cb)
> > base_auto = git_config_bool(var, value);
> >
On Sat, Jul 30, 2016 at 02:41:56AM -0700, Josh Triplett wrote:
> @@ -807,6 +808,17 @@ static int git_format_config(const char *var, const char
> *value, void *cb)
> base_auto = git_config_bool(var, value);
> return 0;
> }
> + if (!strcmp(var, "format.from"))
This helps users who would prefer format-patch to default to --from, and
makes it easier to change the default in the future.
Signed-off-by: Josh Triplett
---
Documentation/config.txt | 10 +++-
builtin/log.c | 13 -
contrib/completion/git-compl
6 matches
Mail list logo
