Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-05 Thread Jeff King
On Wed, Apr 06, 2016 at 01:53:35AM -0400, Eric Sunshine wrote: > On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto wrote: > > 2016-04-01 22:25 GMT+02:00 Eric Sunshine : > >> In addition to review comments by others, why are the new curl_dump() > >> and curl_trace() functions duplicated in both patches r

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-05 Thread Eric Sunshine
On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto wrote: > 2016-04-01 22:25 GMT+02:00 Eric Sunshine : >> In addition to review comments by others, why are the new curl_dump() >> and curl_trace() functions duplicated in both patches rather than >> factored out to a shared implementation? > > It's right. D

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-05 Thread Elia Pinto
2016-04-01 22:25 GMT+02:00 Eric Sunshine : > On Fri, Apr 1, 2016 at 6:44 AM, Elia Pinto wrote: >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >> transport header and all the data payload exchanged. >> It

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-04 Thread Junio C Hamano
Elia Pinto writes: >> My impression is that using GIT_TRACE_* is the more mainstream >> trend, and it may be beneficial to work any new debugging aid like >> this one to fit within that mechanism. > > I thought about it, and I agree with you. The idea could be > > - Call the variable GIT_TRACE_CU

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-04 Thread Elia Pinto
2016-04-01 17:35 GMT+02:00 Junio C Hamano : > Elia Pinto writes: > >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >> transport header and all the data payload exchanged. >> It might be useful if a particu

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-04 Thread Elia Pinto
2016-04-01 16:56 GMT+02:00 Ramsay Jones : > > > On 01/04/16 11:44, Elia Pinto wrote: >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >> transport header and all the data payload exchanged. >> It might be us

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 Thread Eric Sunshine
On Fri, Apr 1, 2016 at 6:44 AM, Elia Pinto wrote: > Implements the GIT_CURL_DEBUG environment variable to allow a greater > degree of detail of GIT_CURL_VERBOSE, in particular the complete > transport header and all the data payload exchanged. > It might be useful if a particular situation could r

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 Thread Junio C Hamano
Elia Pinto writes: > Implements the GIT_CURL_DEBUG environment variable to allow a greater > degree of detail of GIT_CURL_VERBOSE, in particular the complete > transport header and all the data payload exchanged. > It might be useful if a particular situation could require a more > thorough debug

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 Thread Ramsay Jones
On 01/04/16 11:44, Elia Pinto wrote: > Implements the GIT_CURL_DEBUG environment variable to allow a greater > degree of detail of GIT_CURL_VERBOSE, in particular the complete > transport header and all the data payload exchanged. > It might be useful if a particular situation could require a mor

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 Thread Torsten Bögershausen
On 01.04.16 12:44, Elia Pinto wrote: > Implements the GIT_CURL_DEBUG environment variable to allow a greater > degree of detail of GIT_CURL_VERBOSE, in particular the complete > transport header and all the data payload exchanged. > It might be useful if a particular situation could require a more

[PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 Thread Elia Pinto
Implements the GIT_CURL_DEBUG environment variable to allow a greater degree of detail of GIT_CURL_VERBOSE, in particular the complete transport header and all the data payload exchanged. It might be useful if a particular situation could require a more thorough debugging analysis. Signed-off-by: