CodingGuidelines Perl amendment (was: [PATCH 1/3] Add contrib/credentials/netrc with GPG support)

2013-02-06 Thread Ted Zlatanov
On Mon, 04 Feb 2013 15:10:45 -0800 Junio C Hamano wrote: JCH> Ted Zlatanov writes: JCH> I thought that we tend to avoid Emacs/Vim formatting cruft left in JCH> the file. Do we have any in existing file outside contrib/? >> >> No, but it's a nice way to express the settings so no one is guessi

Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support

2013-02-04 Thread Junio C Hamano
Ted Zlatanov writes: > JCH> I thought that we tend to avoid Emacs/Vim formatting cruft left in > JCH> the file. Do we have any in existing file outside contrib/? > > No, but it's a nice way to express the settings so no one is guessing > what the project prefers. At least for me it's not an iss

Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support

2013-02-04 Thread Ted Zlatanov
On Mon, 04 Feb 2013 11:06:16 -0800 Junio C Hamano wrote: JCH> Ted Zlatanov writes: >> Sorry, I didn't realize contrib/ stuff was under the same rules. JCH> I had a feeling that this may start out from contrib/ but will soon JCH> prove to be fairly important to be part of the Git proper. Cool!

Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support

2013-02-04 Thread Junio C Hamano
Ted Zlatanov writes: > Sorry, I didn't realize contrib/ stuff was under the same rules. I had a feeling that this may start out from contrib/ but will soon prove to be fairly important to be part of the Git proper. > It would help if the requirements were codified as the fairly standard > Emacs

Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support

2013-02-04 Thread Ted Zlatanov
On Mon, 04 Feb 2013 09:24:03 -0800 Junio C Hamano wrote: JCH> [administrivia: I would really wish you didn't put "Mail-copies-to: JCH> never" above]. I normally post through GMane and don't need the extra CC on any list I read. I'll make an effort to remove that header here, and apologize for

Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support

2013-02-04 Thread Junio C Hamano
[administrivia: I would really wish you didn't put "Mail-copies-to: never" above]. Ted Zlatanov writes: > +foreach my $v (values %{$options{tmap}}) > +{ > + $options{tmap}->{$v} = $v; > +} Please follow the styles of existing Perl scripts, e.g. indent with tab, etc. Style requests are not opti

Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support

2013-02-04 Thread Ted Zlatanov
Grr, sorry for the bad formatting. First time doing format-patch. Ted -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] Add contrib/credentials/netrc with GPG support

2013-02-04 Thread Ted Zlatanov
Signed-off-by: Ted Zlatanov --- contrib/credential/netrc/git-credential-netrc | 242 + 1 files changed, 242 insertions(+), 0 deletions(-) create mode 100755 contrib/credential/netrc/git-credential-netrc diff --git a/contrib/credential/netrc/git-credential-netrc b/cont