Re: [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines.

2013-07-19 Thread Junio C Hamano
Stefan Beller writes: > So is there any up-to-date task list for beginning contributors? I am fairly bad at keeping track of small things incrementally, as it is often quicker to do them myself if/when I were so inclined, but there are too many of them and a day does not have enough number of se

Re: [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines.

2013-07-19 Thread Stefan Beller
On 07/19/2013 08:13 PM, Junio C Hamano wrote: > The "ret" was meant to mean "the return value we got from the > callback function", not "the return value we would give our caller". Thanks for clarifying. I assumed the "ret" was meant as the return value of that function as it was the case before e

Re: [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines.

2013-07-19 Thread Junio C Hamano
The "ret" was meant to mean "the return value we got from the callback function", not "the return value we would give our caller". This rename is a bit misleading in that "cb_bits == -1" does not mean "full bits set", and it does not tell us much what these "bits" signify. They are used to answer

[PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines.

2013-07-18 Thread Stefan Beller
The variable name ret sounds like the variable to be returned, but since e6c111b4 we return error. Hence the variable name is miss leading. As this variable is used only to extract the bits from the callback of a tree object, I named it cb_bits for callback bits. Also the assignment to 0 was remov