Am 12.06.2014 21:12, schrieb Junio C Hamano:
Karsten Blees karsten.bl...@gmail.com writes:
Am 10.06.2014 12:17, schrieb Heiko Voigt:
The intention of Jonathans critique here[1] was that you do not see what
this parameter does on the callsite. I.e.:
hashmap_free(map, 1);
compared to
On Tue, Jun 17, 2014 at 10:30:35AM +0200, Karsten Blees wrote:
Am 12.06.2014 21:12, schrieb Junio C Hamano:
Karsten Blees karsten.bl...@gmail.com writes:
Am 10.06.2014 12:17, schrieb Heiko Voigt:
The intention of Jonathans critique here[1] was that you do not see what
this parameter
Heiko Voigt hvo...@hvoigt.net writes:
If this is such a controversial change for you I will drop this patch in
the next round. I think it would make the callsite more readable without
adding much clutter but I am fine with it either way.
OK, let's do that.
--
To unsubscribe from this list:
Karsten Blees karsten.bl...@gmail.com writes:
Am 10.06.2014 12:17, schrieb Heiko Voigt:
The intention of Jonathans critique here[1] was that you do not see what
this parameter does on the callsite. I.e.:
hashmap_free(map, 1);
compared to
hashmap_free(map,
Am 10.06.2014 12:17, schrieb Heiko Voigt:
On Fri, Jun 06, 2014 at 07:52:03PM +0200, Karsten Blees wrote:
Am 05.06.2014 08:06, schrieb Heiko Voigt:
This allows a reader to immediately know which options can be used and
what this parameter is about.
[...]
-void hashmap_free(struct hashmap
On Fri, Jun 06, 2014 at 07:52:03PM +0200, Karsten Blees wrote:
Am 05.06.2014 08:06, schrieb Heiko Voigt:
This allows a reader to immediately know which options can be used and
what this parameter is about.
[...]
-void hashmap_free(struct hashmap *map, int free_entries)
+void
Am 05.06.2014 08:06, schrieb Heiko Voigt:
This allows a reader to immediately know which options can be used and
what this parameter is about.
[...]
-void hashmap_free(struct hashmap *map, int free_entries)
+void hashmap_free(struct hashmap *map, enum hashmap_free_options
free_entries)
This allows a reader to immediately know which options can be used and
what this parameter is about.
Signed-off-by: Heiko Voigt hvo...@hvoigt.net
---
Documentation/technical/api-hashmap.txt | 2 +-
diffcore-rename.c | 2 +-
hashmap.c | 2 +-
8 matches
Mail list logo