Re: fixup! [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-27 Thread Andreas Heiduk
Am 12.04.2018 um 21:36 schrieb Martin Ågren: > On 11 April 2018 at 23:08, Andreas Heiduk wrote: >> - reflow some paragraphs >> --- >> Documentation/githooks.txt | 14 +++--- >> 1 file changed, 7 insertions(+), 7 deletions(-) > > I have reviewed the resulting githooks.txt. See the diff bel

Re: fixup! [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-12 Thread Martin Ågren
On 11 April 2018 at 23:08, Andreas Heiduk wrote: > - reflow some paragraphs > --- > Documentation/githooks.txt | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) I have reviewed the resulting githooks.txt. See the diff below for two more instances that I found. For the second

fixup! [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-11 Thread Andreas Heiduk
- reflow some paragraphs --- Documentation/githooks.txt | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt index be31376767..ab5ce80e13 100644 --- a/Documentation/githooks.txt +++ b/Documentation/githooks.txt @

fixup! [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-11 Thread Andreas Heiduk
- add linkgit: to callers of hooks - change 'git-foo' and similar to `git foo` - add some more `` for fsmonitor --- Documentation/githooks.txt | 101 +++-- 1 file changed, 51 insertions(+), 50 deletions(-) diff --git a/Documentation/githooks.txt b/Documenta

Re: [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-11 Thread Andreas Heiduk
So the following two fixups should cleanup that page considerably.

Re: [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-10 Thread Junio C Hamano
Martin Ågren writes: > Your reading seems correct, so I was wrong in my speculation. My guess > is such a patch would be welcome. I checked a couple of man-pages and > this one seems particularly heavy on 'git foo' as opposed to `git foo`. > I think that's a reason to fix it, not to leave it behi

Re: [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-10 Thread Martin Ågren
On 10 April 2018 at 22:04, Andreas Heiduk wrote: > Am 10.04.2018 um 21:13 schrieb Martin Ågren: >> On 10 April 2018 at 20:32, Andreas Heiduk wrote: >> Hmm, I wonder if that is actually intentional. `git commit --amend` >> could be run exactly like that and would do what this paragraph expects >>

Re: [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-10 Thread Andreas Heiduk
Am 10.04.2018 um 21:13 schrieb Martin Ågren: > On 10 April 2018 at 20:32, Andreas Heiduk wrote: >> The section 'post-rewrite' in 'githooks.txt' renders only one command >> using backticks (`git commit`) but the other commands using single quotes >> ('git-rebase'). Align this formatting to use sing

Re: [PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-10 Thread Martin Ågren
On 10 April 2018 at 20:32, Andreas Heiduk wrote: > The section 'post-rewrite' in 'githooks.txt' renders only one command > using backticks (`git commit`) but the other commands using single quotes > ('git-rebase'). Align this formatting to use single quotes. > > Signed-off-by: Andreas Heiduk > --

[PATCH 1/6] doc: fix formatting inconsistency in githooks.txt

2018-04-10 Thread Andreas Heiduk
The section 'post-rewrite' in 'githooks.txt' renders only one command using backticks (`git commit`) but the other commands using single quotes ('git-rebase'). Align this formatting to use single quotes. Signed-off-by: Andreas Heiduk --- Documentation/githooks.txt | 4 ++-- 1 file changed, 2 ins