Re: [PATCH 11/11] walker.c: use ref transaction for ref updates

2014-04-21 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote: Switch to using ref transactions in walker_fetch(). As part of the refactoring to use ref transactions we also fix a potential memory leak where in the original code if write_ref_sha1() would fail

Re: [PATCH 11/11] walker.c: use ref transaction for ref updates

2014-04-21 Thread Ronnie Sahlberg
I have updated the commit message with some text why I do not think this change is critical for this case. I will resend v2 of the patch series in a little while. On Sat, Apr 19, 2014 at 12:48 PM, Michael Haggerty mhag...@alum.mit.edu wrote: On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote: Switch

Re: [PATCH 11/11] walker.c: use ref transaction for ref updates

2014-04-19 Thread Michael Haggerty
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote: Switch to using ref transactions in walker_fetch(). As part of the refactoring to use ref transactions we also fix a potential memory leak where in the original code if write_ref_sha1() would fail we would end up returning from the function

[PATCH 11/11] walker.c: use ref transaction for ref updates

2014-04-17 Thread Ronnie Sahlberg
Switch to using ref transactions in walker_fetch(). As part of the refactoring to use ref transactions we also fix a potential memory leak where in the original code if write_ref_sha1() would fail we would end up returning from the function without free()ing the msg string. Signed-off-by: Ronnie