Re: [PATCH 16/19] reset [--mixed] --quiet: don't refresh index

2013-01-09 Thread Junio C Hamano
Martin von Zweigbergk writes: > There is a test case in t7102 called '--mixed refreshes the index', > but it only checks that right output it printed. I think that comes from 620a6cd (builtin-reset: avoid forking "update-index --refresh", 2007-11-03). Before that commit, we refreshed the index

Re: [PATCH 16/19] reset [--mixed] --quiet: don't refresh index

2013-01-09 Thread Martin von Zweigbergk
On Wed, Jan 9, 2013 at 11:12 AM, Junio C Hamano wrote: > Martin von Zweigbergk writes: > > And as a Porcelain, I would rather expect it to leave the resulting > index refreshed. Yeah, I guess you're right. Regular users (those using only porcelain) shouldn't notice, but it does make sense to thi

Re: [PATCH 16/19] reset [--mixed] --quiet: don't refresh index

2013-01-09 Thread Junio C Hamano
Martin von Zweigbergk writes: >> We have never been very clear about which commands refresh the index. > > Yes, git-reset's documentation doesn't mention it. > >> Since "reset" is about manipulating the index, I'd expect it to be >> refreshed afterwards. On the other hand, since we have never gua

Re: [PATCH 16/19] reset [--mixed] --quiet: don't refresh index

2013-01-09 Thread Martin von Zweigbergk
On Wed, Jan 9, 2013 at 9:01 AM, Jeff King wrote: > On Wed, Jan 09, 2013 at 12:16:13AM -0800, Martin von Zweigbergk wrote: > >> "git reset [--mixed]" without --quiet refreshes the index in order to >> display the "Unstaged changes after reset". When --quiet is given, >> that output is suppressed, r

Re: [PATCH 16/19] reset [--mixed] --quiet: don't refresh index

2013-01-09 Thread Jeff King
On Wed, Jan 09, 2013 at 12:16:13AM -0800, Martin von Zweigbergk wrote: > "git reset [--mixed]" without --quiet refreshes the index in order to > display the "Unstaged changes after reset". When --quiet is given, > that output is suppressed, removing the need to refresh the index. > Other porcelain

[PATCH 16/19] reset [--mixed] --quiet: don't refresh index

2013-01-09 Thread Martin von Zweigbergk
"git reset [--mixed]" without --quiet refreshes the index in order to display the "Unstaged changes after reset". When --quiet is given, that output is suppressed, removing the need to refresh the index. Other porcelain commands that care about a refreshed index should already be refreshing it, so