Re: [PATCH 2/3] midx: close multi-pack-index on repack

2018-10-09 Thread Stefan Beller
On Tue, Oct 9, 2018 at 7:11 AM Derrick Stolee wrote: > > CC Stefan: Is there a plan to make get_object_directory() take a > repository parameter? Not an immediate plan. Regarding the large refactorings I am mostly waiting for nd/the-index to stabilize (which may be stable enough by now) before

Re: [PATCH 2/3] midx: close multi-pack-index on repack

2018-10-09 Thread Derrick Stolee
On 10/9/2018 5:10 AM, Junio C Hamano wrote: "Derrick Stolee via GitGitGadget" writes: diff --git a/builtin/repack.c b/builtin/repack.c index c6a7943d5c..7925bb976e 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -432,6 +432,10 @@ int cmd_repack(int argc, const char **argv, const char

Re: [PATCH 2/3] midx: close multi-pack-index on repack

2018-10-09 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > diff --git a/builtin/repack.c b/builtin/repack.c > index c6a7943d5c..7925bb976e 100644 > --- a/builtin/repack.c > +++ b/builtin/repack.c > @@ -432,6 +432,10 @@ int cmd_repack(int argc, const char **argv, const char > *prefix) > >

[PATCH 2/3] midx: close multi-pack-index on repack

2018-10-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee When repacking, we may remove pack-files. This invalidates the multi-pack-index (if it exists). Previously, we removed the multi-pack-index file before removing any pack-file. In some cases, the repack command may load the multi-pack-index into memory. This may lead to later