Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'

2017-07-12 Thread Brandon Williams
On 07/11, Stefan Beller wrote: > On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams wrote: > > > + if (repo_submodule_init(, superproject, path)) > > + return 0; > > What happens if we go through the "return 0", do we rather want to > print an error ?

Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'

2017-07-12 Thread Brandon Williams
On 07/11, Jacob Keller wrote: > On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams wrote: > > Convert grep to use 'struct repository' which enables recursing into > > submodules to be handled in-process. > > > > Signed-off-by: Brandon Williams > > --- > >

Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'

2017-07-12 Thread Brandon Williams
On 07/11, Jonathan Nieder wrote: > Hi, > > Brandon Williams wrote: > > > Convert grep to use 'struct repository' which enables recursing into > > submodules to be handled in-process. > > \o/ > > This will be even nicer with the changes described at >

Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'

2017-07-11 Thread Jonathan Nieder
Hi, Brandon Williams wrote: > Convert grep to use 'struct repository' which enables recursing into > submodules to be handled in-process. \o/ This will be even nicer with the changes described at https://public-inbox.org/git/20170706202739.6056-1-sbel...@google.com/. Until then, I fear it will

Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'

2017-07-11 Thread Stefan Beller
On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams wrote: > + if (repo_submodule_init(, superproject, path)) > + return 0; What happens if we go through the "return 0", do we rather want to print an error ? > + /* add objects to alternates */ > +

Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'

2017-07-11 Thread Jacob Keller
On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams wrote: > Convert grep to use 'struct repository' which enables recursing into > submodules to be handled in-process. > > Signed-off-by: Brandon Williams > --- > Documentation/git-grep.txt | 7 - >

[PATCH 3/3] grep: recurse in-process using 'struct repository'

2017-07-11 Thread Brandon Williams
Convert grep to use 'struct repository' which enables recursing into submodules to be handled in-process. Signed-off-by: Brandon Williams --- Documentation/git-grep.txt | 7 - builtin/grep.c | 390 + cache.h