[PATCH 3/7] diff.c: do not pass diff options as keydata to hashmap

When we initialize the hashmap, we give it a pointer to the diff_options, which it then passes along to each call of the hashmap_cmp_fn function. There's no need to pass it a second time as the "keydata" parameter, and our comparison functions never look at keydata. This was a mistake left over fr

Re: [PATCH 3/7] diff.c: do not pass diff options as keydata to hashmap

Hi Jeff, On Fri, Apr 6, 2018 at 1:04 PM, Jeff King wrote: > On Mon, Apr 02, 2018 at 03:48:50PM -0700, Stefan Beller wrote: > >> The diff options are passed to the compare function as >> 'hashmap_cmp_fn_data', which are given when the hashmaps >> are initialized. >> >> A later patch will make use

Re: [PATCH 3/7] diff.c: do not pass diff options as keydata to hashmap

On Mon, Apr 02, 2018 at 03:48:50PM -0700, Stefan Beller wrote: > The diff options are passed to the compare function as > 'hashmap_cmp_fn_data', which are given when the hashmaps > are initialized. > > A later patch will make use of the keydata to signal > different settings for comparision. I h

[PATCH 3/7] diff.c: do not pass diff options as keydata to hashmap

The diff options are passed to the compare function as 'hashmap_cmp_fn_data', which are given when the hashmaps are initialized. A later patch will make use of the keydata to signal different settings for comparision. Signed-off-by: Stefan Beller --- diff.c | 4 ++-- 1 file changed, 2 insertion