Re: [PATCH 6/6] log --grep: honor grep.patterntype etc. configuration variables

2012-10-04 Thread Jeff King
On Wed, Oct 03, 2012 at 06:33:39PM -0700, Junio C Hamano wrote: Read grep.extendedregexp, grep.patterntype, etc. from the configuration so that log --grep='pcre' honors the user preference without an explicit -P from the command line. Now that the callback parameter, which was so far

Re: [PATCH 6/6] log --grep: honor grep.patterntype etc. configuration variables

2012-10-04 Thread Junio C Hamano
Jeff King p...@peff.net writes: Hmm. So I think this is a nice feature for some people, but I wonder if we would run into any plumbing compatibility issues. People do tend to use log as plumbing (since rev-list is not as capable). On the other hand, I'd think most internal uses of log --grep

Re: [PATCH 6/6] log --grep: honor grep.patterntype etc. configuration variables

2012-10-04 Thread Jeff King
On Thu, Oct 04, 2012 at 09:46:42AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: Hmm. So I think this is a nice feature for some people, but I wonder if we would run into any plumbing compatibility issues. People do tend to use log as plumbing (since rev-list is not as

Re: [PATCH 6/6] log --grep: honor grep.patterntype etc. configuration variables

2012-10-04 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Thu, Oct 04, 2012 at 09:46:42AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: Hmm. So I think this is a nice feature for some people, but I wonder if we would run into any plumbing compatibility issues. People do tend to use log as

[PATCH 6/6] log --grep: honor grep.patterntype etc. configuration variables

2012-10-03 Thread Junio C Hamano
Read grep.extendedregexp, grep.patterntype, etc. from the configuration so that log --grep='pcre' honors the user preference without an explicit -P from the command line. Now that the callback parameter, which was so far unused, to git_log_config() has to be of type struct rev_info *, stop