Re: [PATCH lt/block-sha1 0/2 v3] block-sha1: avoid pointer conversion that violates alignment constraints

2012-07-22 Thread Junio C Hamano
Jonathan Nieder writes: > Junio C Hamano wrote: >> Jonathan Nieder writes: > >>> The big-endian part was just my idiocy, sorry. >> >> Hrm, do we want an update log message for 1/2 then? > > Hm, I thought all the crazy had been eliminated already. > > *looks again* > > I guess "using a single 32-

Re: [PATCH lt/block-sha1 0/2 v3] block-sha1: avoid pointer conversion that violates alignment constraints

2012-07-22 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >> The big-endian part was just my idiocy, sorry. > > Hrm, do we want an update log message for 1/2 then? Hm, I thought all the crazy had been eliminated already. *looks again* I guess "using a single 32-bit load" makes it sound like it's using a

Re: [PATCH lt/block-sha1 0/2 v3] block-sha1: avoid pointer conversion that violates alignment constraints

2012-07-22 Thread Junio C Hamano
Jonathan Nieder writes: > Junio C Hamano wrote: > >> Thanks. >> >> Did somebody actually compiled Git for Alpha, and even more >> surprisingly on a big-endian variant of one? > > Logs from building for Alpha and running the test suite are here: > > http://buildd.debian-ports.org/status/logs.php?

Re: [PATCH lt/block-sha1 0/2 v3] block-sha1: avoid pointer conversion that violates alignment constraints

2012-07-22 Thread Jonathan Nieder
Junio C Hamano wrote: > Thanks. > > Did somebody actually compiled Git for Alpha, and even more > surprisingly on a big-endian variant of one? Logs from building for Alpha and running the test suite are here: http://buildd.debian-ports.org/status/logs.php?pkg=git&arch=alpha The big-endian part

Re: [PATCH lt/block-sha1 0/2 v3] block-sha1: avoid pointer conversion that violates alignment constraints

2012-07-22 Thread Junio C Hamano
Jonathan Nieder writes: > This is a series of two patches: the first avoids alignment faults > that were making git either slow on Alpha machines or crashy, > depending on the machine's configuration, and the second patch is a > cosmetic nit noticed while reviewing the first. > ... > Thoughts? >

[PATCH lt/block-sha1 0/2 v3] block-sha1: avoid pointer conversion that violates alignment constraints

2012-07-22 Thread Jonathan Nieder
Hi Junio, This is a series of two patches: the first avoids alignment faults that were making git either slow on Alpha machines or crashy, depending on the machine's configuration, and the second patch is a cosmetic nit noticed while reviewing the first. Patches are based against 30ae47b4 remo