Re: [PATCH v2] commit-template: change a message to be more intuitive

2017-09-14 Thread Junio C Hamano
Jeff King writes: > # >8 > # Do not modify or remove the line above. > # Everything below will be ignored. > > (I might say "everything below it" to be more precise). > > I dunno. We are deep in bikeshed territory here, and I

Re: [PATCH v2] commit-template: change a message to be more intuitive

2017-09-14 Thread Kaartic Sivaraam
On Thu, 2017-09-14 at 09:36 +0200, Michael J Gruber wrote: > > Also, given all the translations that we have, it seems somewhat strange > to try and foresee and workaround possible misunderstandings of commonly > used English phrases. In case you're trying to say that "Translators have

Re: [PATCH v2] commit-template: change a message to be more intuitive

2017-09-14 Thread Jeff King
On Thu, Sep 14, 2017 at 07:47:51PM +0530, Kaartic Sivaraam wrote: > > > - const char *explanation = _("Do not touch the line above.\nEverything > > > below will be removed."); > > > + const char *explanation = _("Do not modify or remove the line > > > above.\nEverything below will be

Re: [PATCH v2] commit-template: change a message to be more intuitive

2017-09-14 Thread Kaartic Sivaraam
On Thursday 14 September 2017 01:06 PM, Michael J Gruber wrote: Kaartic Sivaraam venit, vidit, dixit 13.09.2017 15:05: void wt_status_add_cut_line(FILE *fp) { - const char *explanation = _("Do not touch the line above.\nEverything below will be removed."); + const char

Re: [PATCH v2] commit-template: change a message to be more intuitive

2017-09-14 Thread Michael J Gruber
Kaartic Sivaraam venit, vidit, dixit 13.09.2017 15:05: > It's not good to use the phrase 'do not touch' to convey the information > that the cut-line should not be modified or removed as it could possibly > be mis-interpreted by a person who doesn't know that the word 'touch' has > the meaning of

[PATCH v2] commit-template: change a message to be more intuitive

2017-09-13 Thread Kaartic Sivaraam
It's not good to use the phrase 'do not touch' to convey the information that the cut-line should not be modified or removed as it could possibly be mis-interpreted by a person who doesn't know that the word 'touch' has the meaning of 'tamper with'. Further, it could make translations a little

[PATCH v2] commit-template: change a message to be more intuitive

2017-09-13 Thread Kaartic Sivaraam
Changes in v2: - Changed the message as suggested by Jeff - Made the commit message to be even more clear --- Kaartic