Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR

2017-02-14 Thread Jeff King
On Tue, Feb 14, 2017 at 11:08:05AM -0800, Junio C Hamano wrote: > Thanks for prodding. I'm tempted to just rip out everything other > than the 5-liner fix to transport.c and apply it, expecting that a > follow-up patch with updated tests to come sometime not in too > distant future. I think we

Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR

2017-02-14 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 29, 2016 at 07:48:45PM -0500, Jeff King wrote: > >> On Thu, Dec 29, 2016 at 04:11:14PM -0800, Jonathan Nieder wrote: >> >> > Thanks. Here's the patch again, now with commit messages and a test. >> > Thanks for the analysis and sorry for the slow

Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR

2017-02-13 Thread Jeff King
On Thu, Dec 29, 2016 at 07:48:45PM -0500, Jeff King wrote: > On Thu, Dec 29, 2016 at 04:11:14PM -0800, Jonathan Nieder wrote: > > > Thanks. Here's the patch again, now with commit messages and a test. > > Thanks for the analysis and sorry for the slow turnaround. > > Thanks for following up.

Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR

2016-12-29 Thread Jeff King
On Thu, Dec 29, 2016 at 04:37:30PM -0800, Stefan Beller wrote: > > + mkdir lsremote-root && > > + ( > > + GIT_CEILING_DIRECTORIES=$(pwd) && > > + export GIT_CEILING_DIRECTORIES && > > + cd lsremote-root && > > + git ls-remote

Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR

2016-12-29 Thread Jeff King
On Thu, Dec 29, 2016 at 04:11:14PM -0800, Jonathan Nieder wrote: > Thanks. Here's the patch again, now with commit messages and a test. > Thanks for the analysis and sorry for the slow turnaround. Thanks for following up. While working on a similar one recently, I had the nagging feeling that

Re: [PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR

2016-12-29 Thread Stefan Beller
> + mkdir lsremote-root && > + ( > + GIT_CEILING_DIRECTORIES=$(pwd) && > + export GIT_CEILING_DIRECTORIES && > + cd lsremote-root && > + git ls-remote "$HTTPD_URL/smart/repo.git" >../actual > + ) && We could avoid the

[PATCH v2] remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR

2016-12-29 Thread Jonathan Nieder
To push from or fetch to the current repository, remote helpers need to know what repository that is. Accordingly, Git sets the GIT_DIR environment variable to the path to the current repository when invoking remote helpers. There is a special case it does not handle: "git ls-remote" and "git