Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-12-26 Thread Adam Spiers
On Thu, Sep 20, 2012 at 10:43 PM, Junio C Hamano wrote: > Junio C Hamano writes: >> Adam Spiers writes: >>> Adam Spiers (14): >>> Update directory listing API doc to match code >>> Improve documentation and comments regarding directory traversal API >>> Rename cryptic 'which' variable to m

Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-09-24 Thread Junio C Hamano
Adam Spiers writes: > t/t0007-ignores.sh| 587 > ++ I needed this to make it pass the test. I didn't see anything that is passed to expect_in via $text that would benefit from "echo -e" but I did not look too carefully; you may have had a reas

Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-09-21 Thread Junio C Hamano
Adam Spiers writes: > It has been rebased on the latest master, and passed a full test run. FYI, I applied the attached on top before queuing it in 'pu'. Points to note: * We match the underline and the title of documentation header; * a few type mismatches (constness of full_path and treat

Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-09-20 Thread Junio C Hamano
Adam Spiers writes: > Sure, I can do that, but shouldn't this convention be documented in > SubmittingPatches? People must have learned this by imitating what senior contributors send to the list, but the "[Subject] area: title" thing does not appear in that document. I agree it should (patches

Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-09-20 Thread Adam Spiers
On Thu, Sep 20, 2012 at 10:43 PM, Junio C Hamano wrote: > Junio C Hamano writes: >> Adam Spiers writes: >>> Adam Spiers (14): >>> Update directory listing API doc to match code >>> Improve documentation and comments regarding directory traversal API >>> Rename cryptic 'which' variable to m

Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-09-20 Thread Junio C Hamano
Junio C Hamano writes: > Adam Spiers writes: > >> Adam Spiers (14): >> Update directory listing API doc to match code >> Improve documentation and comments regarding directory traversal API >> Rename cryptic 'which' variable to more consistent name >> Rename path_excluded() to is_path_ex

Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-09-20 Thread Junio C Hamano
Adam Spiers writes: > Adam Spiers (14): > Update directory listing API doc to match code > Improve documentation and comments regarding directory traversal API > Rename cryptic 'which' variable to more consistent name > Rename path_excluded() to is_path_excluded() > Rename excluded_from

[PATCH v2 00/14] new git check-ignore sub-command

2012-09-20 Thread Adam Spiers
This is a re-vamp of my original check-ignore series, which aims to address all the feedback which was raised in the first round of reviews. The most notable changes are the CLI options and output formats as suggested by Junio and Nguyễn; now there are three levels of verbosity: --quiet, default,