Jeff King writes:
> Thanks both for the explanation. I don't see us using that to our
> advantage anywhere in the patch. So I think this is purely a style
> issue, which to me indicates that the extra dependency is not worth it,
> and the patch should be dropped.
Same here: I'd rather keep the
On Sat, Jun 08, 2013 at 03:01:03PM +0200, Célestin Perdu wrote:
> Oh yes, part of this commit went into the previous one, which was not
> formated as an email when I did my git-format-patch. I should check my
> patches more carefully before sending them. Sorry for this.
No problem. It is easy to
Le 08/06/2013 05:23, Jeff King a écrit :
> What does this series apply on top of? The existing version in "master"
> does not have "use Readonly" in it at all. The first version of your
> series introduced that line, but here it is shown as an existing line.
> Did you miss a commit when putting you
The major drawback of using perl `constant` is the fact that they do
not interpolate like variables in most of the contexts (those who
automatically quotes barewords). Like said on Perl Monks here [1], you
have to do some "tricks" depending on the context in which you're
using the constant and that
On Fri, Jun 07, 2013 at 11:42:03PM +0200, Célestin Matte wrote:
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
> b/contrib/mw-to-git/git-remote-mediawiki.perl
> index 4893442..e60793a 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki.perl
> +++ b/contrib/mw-to-git/git-remote-media
Follow ValuesAndExpressions::ProhibitConstantPragma
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki
6 matches
Mail list logo
