Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Am 09.10.2016 um 10:57 schrieb Johannes Schindelin: Good point. I decided to do it at a different level, though: parse_insn_line() should already receive the line without trailing end-of-line markers (this was already the case for LF-only todo scripts). I reused your commit message and touched

Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Hi Hannes, On Thu, 6 Oct 2016, Johannes Sixt wrote: > [PATCH] sequencer: strip CR from the end of exec insns > > It is not unheard of that editors on Windows write CRLF even if the file > originally had only LF. This is particularly awkward for exec lines of a > rebase -i todo sheet. Take for

Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Johannes Sixt writes: > Let me take the opportunity to say > >Thank You Very Much! > > for the new implementation of rebase -i. I'm using your branch > rebase-i-extra, and it is such a pleasure to work with on Windows > compared to the old fully scripted version. Thanks for

Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Am 06.10.2016 um 15:08 schrieb Johannes Schindelin: > Hi Junio, > > On Mon, 12 Sep 2016, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> I do not offhand see why we want to be lenient here, especially only to the left. >>> >>> Postel's Law. >> >>

Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Hi Junio, On Mon, 12 Sep 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> I do not offhand see why we want to be lenient here, > >> especially only to the left. > > > > Postel's Law. > > How would that compare/relate to yagni, though? I did need

Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Johannes Schindelin writes: >> I do not offhand see why we want to be lenient here, >> especially only to the left. > > Postel's Law. How would that compare/relate to yagni, though?

Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Hi Junio, On Sun, 11 Sep 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Interactive rebase's scripts may be indented; we need to handle this > > case, too, now that we prepare the sequencer to process interactive > > rebases. > > Hmph, have we ever

Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

Johannes Schindelin writes: > Interactive rebase's scripts may be indented; we need to handle this > case, too, now that we prepare the sequencer to process interactive > rebases. Hmph, have we ever given the sequencer instructions indented to the user to edit? I do

[PATCH v2 20/25] sequencer: left-trim lines read from the script

Interactive rebase's scripts may be indented; we need to handle this case, too, now that we prepare the sequencer to process interactive rebases. Signed-off-by: Johannes Schindelin --- sequencer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sequencer.c