Re: [PATCH v3 2/5] tree-walk.c: remove name_compare() function

2014-06-19 Thread Jeremiah Mahler
Jonathan, On Wed, Jun 18, 2014 at 12:03:59PM -0700, Jonathan Nieder wrote: > Jeremiah Mahler wrote: > > > Remove the duplicate name_compare() function and use the one provided by > > read-cache.c. > > I'd squash this into patch 1/5. > > > --- > > Notes: > > There is one small difference bet

Re: [PATCH v3 2/5] tree-walk.c: remove name_compare() function

2014-06-18 Thread Jonathan Nieder
Jeremiah Mahler wrote: > Remove the duplicate name_compare() function and use the one provided by > read-cache.c. I'd squash this into patch 1/5. > --- > Notes: > There is one small difference between the old function and the new one. > The old one returned -N and +N whereas the new one

[PATCH v3 2/5] tree-walk.c: remove name_compare() function

2014-06-18 Thread Jeremiah Mahler
Remove the duplicate name_compare() function and use the one provided by read-cache.c. Signed-off-by: Jeremiah Mahler --- Notes: There is one small difference between the old function and the new one. The old one returned -N and +N whereas the new one returns -1 and +1. However, ther