Jonathan, On Wed, Jun 18, 2014 at 12:03:59PM -0700, Jonathan Nieder wrote: > Jeremiah Mahler wrote: > > > Remove the duplicate name_compare() function and use the one provided by > > read-cache.c. > > I'd squash this into patch 1/5. > > > --- > > Notes: > > There is one small difference between the old function and the new one. > > The old one returned -N and +N whereas the new one returns -1 and +1. > > However, there is no place where the magnitude was needed, so this > > change will not alter its behavior. > > This is useful information for anyone looking back at the patch in the > future, so it belongs above the three-dash divider. > Makes sense. I will add it to the log message.
> Thanks, > Jonathan Thanks, -- Jeremiah Mahler jmmah...@gmail.com http://github.com/jmahler -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
