Re: [PATCH v3 4/4] archive-tar: drop return value

Jeff King writes: > On Fri, Jun 24, 2016 at 01:49:24PM +0200, Remi Galan Alfonso wrote: > >> Hi Peff, >> >> Jeff King writes: >> > @@ -413,7 +411,7 @@ static int write_tar_archive(const struct archiver *ar, >> > { >> > int err = 0; >> > >> > -

Re: [PATCH v3 4/4] archive-tar: drop return value

On Fri, Jun 24, 2016 at 01:49:24PM +0200, Remi Galan Alfonso wrote: > Hi Peff, > > Jeff King writes: > > @@ -413,7 +411,7 @@ static int write_tar_archive(const struct archiver *ar, > > { > > int err = 0; > > > > -err = write_global_extended_header(args); > > +

Re: [PATCH v3 4/4] archive-tar: drop return value

Hi Peff, Jeff King writes: > @@ -413,7 +411,7 @@ static int write_tar_archive(const struct archiver *ar, > { > int err = 0; > > -err = write_global_extended_header(args); > +write_global_extended_header(args); > if (!err) > err

[PATCH v3 4/4] archive-tar: drop return value

We never do any error checks, and so never return anything but "0". Let's just drop this to simplify the code. Signed-off-by: Jeff King --- I wasn't sure if this was perhaps kept as an interface decision, in case the function grew errors later on. If so, it can still drop the