Re: [PATCH v4 0/3] config: add '--sources' option to print the source of a config value

2016-02-16 Thread Lars Schneider
On 15 Feb 2016, at 19:05, Jeff King wrote: > On Mon, Feb 15, 2016 at 11:17:43AM +0100, larsxschnei...@gmail.com wrote: > >> I like the idea of a "test set up block" within a test script. In order >> to clean up nicely before any subsequent tests I would like to propose >> a

Re: [PATCH v4 0/3] config: add '--sources' option to print the source of a config value

2016-02-15 Thread Jeff King
On Mon, Feb 15, 2016 at 11:17:43AM +0100, larsxschnei...@gmail.com wrote: > I like the idea of a "test set up block" within a test script. In order > to clean up nicely before any subsequent tests I would like to propose > a "tear down" block. Would that work as a compromise in our "test cases >

[PATCH v4 0/3] config: add '--sources' option to print the source of a config value

2016-02-15 Thread larsxschneider
From: Lars Schneider diff to v3: * pass type as parameter to "git_config_from_mem" (renamed from "git_config_from_buf") and "do_config_from_file" * split current_config_type_name into two functions * explain usage of fwrite with a comment * use tabs instead of spaces