Re: [PATCH v4 0/3] diff-highlight: add support for --graph option

2016-08-30 Thread Jeff King
On Tue, Aug 30, 2016 at 07:07:11AM -0700, Brian Henderson wrote: > On Mon, Aug 29, 2016 at 02:37:46PM -0700, Junio C Hamano wrote: > > Brian Henderson writes: > > > > > How does this look? > > > > > > Drawing the graph helped me a lot in figuring out what I was > > >

[PATCH v4 0/3] diff-highlight: add support for --graph option

2016-08-30 Thread Brian Henderson
On Mon, Aug 29, 2016 at 02:37:46PM -0700, Junio C Hamano wrote: > Brian Henderson writes: > > > How does this look? > > > > Drawing the graph helped me a lot in figuring out what I was > > actually testing. thanks! > > Yeah, I also am pleased to see the picture of what is

Re: [PATCH v4 0/3] diff-highlight: add support for --graph option

2016-08-30 Thread Jeff King
On Mon, Aug 29, 2016 at 10:33:44AM -0700, Brian Henderson wrote: > How does this look? > > Drawing the graph helped me a lot in figuring out what I was actually > testing. thanks! > > Brian Henderson (3): > diff-highlight: add some tests. > diff-highlight: add failing test for handling

Re: [PATCH v4 0/3] diff-highlight: add support for --graph option

2016-08-29 Thread Junio C Hamano
Brian Henderson writes: > How does this look? > > Drawing the graph helped me a lot in figuring out what I was > actually testing. thanks! Yeah, I also am pleased to see the picture of what is being tested in the test script. With your sign-off, they would have been

[PATCH v4 0/3] diff-highlight: add support for --graph option

2016-08-29 Thread Brian Henderson
How does this look? Drawing the graph helped me a lot in figuring out what I was actually testing. thanks! Brian Henderson (3): diff-highlight: add some tests. diff-highlight: add failing test for handling --graph output. diff-highlight: add support for --graph output.