Re: [PATCH v7 00/10] interactive git clean

2013-05-13 Thread Matthieu Moy
Jiang Xin worldhello@gmail.com writes: My initial intention for flags toggle is for git newbies, who are not clear about how to use -x/-d/-X/-ff options. I feel it may have values for these people. It may have value for some of them, but throwing too many options in a menu is usually

Re: [PATCH v7 00/10] interactive git clean

2013-05-12 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Cleaning all unneeded files inside a single interactive session should *never* be the goal---that will lead to an over-engineered design (e.g. switching clean -x flags in the middle? why?). I think Jiang's latest series is already way over-engineered,

Re: [PATCH v7 00/10] interactive git clean

2013-05-12 Thread Jiang Xin
2013/5/13 Matthieu Moy matthieu@grenoble-inp.fr: Junio C Hamano gits...@pobox.com writes: Cleaning all unneeded files inside a single interactive session should *never* be the goal---that will lead to an over-engineered design (e.g. switching clean -x flags in the middle? why?). I think

[PATCH v7 00/10] interactive git clean

2013-05-08 Thread Jiang Xin
Significant updates since patch v6 series: * Refactor on patch 4/10: split `list_and_choose` into 3 functions, to make it easy to read. * Mark no public functions as static for patch 1-10. * If set 'pager.clean' to true (i.e. isatty(1) is false), die instead of do cleaning. * New

Re: [PATCH v7 00/10] interactive git clean

2013-05-08 Thread Eric Sunshine
On Wed, May 8, 2013 at 7:38 AM, Jiang Xin worldhello@gmail.com wrote: When the command enters the interactive mode, it shows the files and directories to be cleaned, and goes into its interactive command loop. Your current implementation only allows excluding items from the list of files

Re: [PATCH v7 00/10] interactive git clean

2013-05-08 Thread Eric Sunshine
On Wed, May 8, 2013 at 11:15 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, May 8, 2013 at 7:38 AM, Jiang Xin worldhello@gmail.com wrote: *** Commands *** 1: clean 2: edit by patterns3: edit by numbers 4: rm -i 5: flags: none 6:

Re: [PATCH v7 00/10] interactive git clean

2013-05-08 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Wed, May 8, 2013 at 7:38 AM, Jiang Xin worldhello@gmail.com wrote: When the command enters the interactive mode, it shows the files and directories to be cleaned, and goes into its interactive command loop. Your current implementation