Re: [PATCH v8 4/5] Implement line-history search (git log -L)

Junio C Hamano gits...@pobox.com writes: Junio C Hamano gits...@pobox.com writes: Overall, I like this better than the log --follow hack; as the revision traversal is done without any pathspec when being careful and slow (aka -M), you do not suffer from the just use a singleton pathspec

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

Thomas Rast tr...@student.ethz.ch writes: Junio C Hamano gits...@pobox.com writes: I notice that careful and slow is just too slow to be usable even on a small tree like ours. Try running $ git log -M -L:get_name:builtin/describe.c and see how long you have to wait until you hit the

[PATCH v8 4/5] Implement line-history search (git log -L)

This is a rewrite of much of Bo's work, mainly in an effort to split it into smaller, easier to understand routines. The algorithm is built around the struct range_set, which encodes a series of line ranges as intervals [a,b). This is used in two contexts: * A set of lines we are tracking

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

Thomas Rast tr...@student.ethz.ch writes: @@ -138,6 +155,11 @@ Examples This makes sense only when following a strict policy of merging all topic branches when staying on a single integration branch. +git log -L '/int main/',/^}/:main.c:: + + Shows how the function

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

Junio C Hamano gits...@pobox.com writes: +/* + * NEEDSWORK: manually building a diff here is not the Right + * Thing(tm). log -L should be built into the diff pipeline. I am not sure about this design, and do not necessarily agree that wedging this to the diff pipeline is the right future

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

Thomas Rast tr...@student.ethz.ch writes: Junio C Hamano gits...@pobox.com writes: +/* + * NEEDSWORK: manually building a diff here is not the Right + * Thing(tm). log -L should be built into the diff pipeline. I am not sure about this design, and do not necessarily agree that wedging

Re: [PATCH v8 4/5] Implement line-history search (git log -L)

Junio C Hamano gits...@pobox.com writes: Thomas Rast tr...@student.ethz.ch writes: Junio C Hamano gits...@pobox.com writes: +/* + * NEEDSWORK: manually building a diff here is not the Right + * Thing(tm). log -L should be built into the diff pipeline. I am not sure about this design,