Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-10 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Aug 9, 2016 at 2:45 PM, Junio C Hamano wrote: >> becomes easily doable (i.e. subsequent "submodule update" can realize >> that the submodule does not have alternates but it could borrow from >> the submodule in the

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Stefan Beller
On Tue, Aug 9, 2016 at 2:45 PM, Junio C Hamano wrote: > becomes easily doable (i.e. subsequent "submodule update" can realize > that the submodule does not have alternates but it could borrow from > the submodule in the other-super-project-location). I would suggest to

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Junio C Hamano
Stefan Beller writes: > At the time of cloning you may run > > git clone --recursive --reference > or > git clone --recursive --reference-if-able > or > git clone --recursive That's an interesting tangent. I never meant "if-able" to be an end-user visible option

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Stefan Beller
On Tue, Aug 9, 2016 at 11:44 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> The way I understood and implemented it is >> >> here is a path, try to use it as an alternate; if that is not >> an alternate, it's fine too; maybe warn about it,

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Junio C Hamano
Stefan Beller writes: > The way I understood and implemented it is > > here is a path, try to use it as an alternate; if that is not > an alternate, it's fine too; maybe warn about it, but carry > on with the operation. My expectation is without "maybe warn about

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Stefan Beller
On Tue, Aug 9, 2016 at 10:47 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> "you did ask me to use alternates once and for all when setting up the >> superproject: now for this added submodule I don't find the alternate; >> That is strange?" > >

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> "you did ask me to use alternates once and for all when setting up the >> superproject: now for this added submodule I don't find the alternate; >> That is strange?" > > Absolutely. I do not think you

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Junio C Hamano
Stefan Beller writes: > "you did ask me to use alternates once and for all when setting up the > superproject: now for this added submodule I don't find the alternate; > That is strange?" Absolutely. I do not think you should expect a user to remember if s/he used

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Stefan Beller
On Tue, Aug 9, 2016 at 8:49 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> v3: >> >> Thanks to Junios critial questions regarding the design, I took a step back >> to look at the bigger picture. >> >> --super-reference sounds confusing. (what is the

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-09 Thread Junio C Hamano
Stefan Beller writes: > v3: > > Thanks to Junios critial questions regarding the design, I took a step back > to look at the bigger picture. > > --super-reference sounds confusing. (what is the super referring to?) > So drop that approach. > > Instead we'll compute where the

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-08 Thread Jacob Keller
On Mon, Aug 8, 2016 at 9:08 PM, Stefan Beller wrote: > > v3: > > Thanks to Junios critial questions regarding the design, I took a step back > to look at the bigger picture. > > --super-reference sounds confusing. (what is the super referring to?) > So drop that approach. > >

[PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-08 Thread Stefan Beller
v3: Thanks to Junios critial questions regarding the design, I took a step back to look at the bigger picture. --super-reference sounds confusing. (what is the super referring to?) So drop that approach. Instead we'll compute where the reference might be in the superproject scope and ask the

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-08 Thread Stefan Beller
On Sat, Aug 6, 2016 at 10:29 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> Some submodules in the referenced superproject may not be there, >> (they are just not initialized/cloned/checked out), which yields >> an error for now. > > Perhaps you

[PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-06 Thread Stefan Beller
v2: * fixed the p1,2 cleanups * added documentation to patches 5,6 * improved commit message in v4 Thanks, Stefan v1: Currently when cloning a superproject with --recursive and --reference only the superproject learns about its alternates. The submodules are cloned independently,

Re: [PATCHv2 0/6] git clone: Marry --recursive and --reference

2016-08-06 Thread Junio C Hamano
Stefan Beller writes: > Some submodules in the referenced superproject may not be there, > (they are just not initialized/cloned/checked out), which yields > an error for now. Perhaps you can teach "git clone --reference" an new option (--reference-if-able) to do this?