Re: [PATCHv2 10/19] git-submodule.sh: convert test -a/-o to and ||

2014-05-22 Thread Matthieu Moy
Elia Pinto gitter.spi...@gmail.com writes: This is version 2 of the patch to git-submodule of the patch series convert test -a/-o to and ||. It contains the fixes identified by Johannes and Matthieu. This version of the patch (not the whole series) is Reviewed-by: Matthieu Moy

Re: [PATCHv2 10/19] git-submodule.sh: convert test -a/-o to and ||

2014-05-22 Thread Elia Pinto
2014-05-22 8:49 GMT+02:00 Matthieu Moy matthieu@grenoble-inp.fr: Elia Pinto gitter.spi...@gmail.com writes: This is version 2 of the patch to git-submodule of the patch series convert test -a/-o to and ||. It contains the fixes identified by Johannes and Matthieu. This version of the

Re: [PATCHv2 10/19] git-submodule.sh: convert test -a/-o to and ||

2014-05-22 Thread Johannes Sixt
Am 5/22/2014 10:38, schrieb Elia Pinto: 2014-05-22 8:49 GMT+02:00 Matthieu Moy matthieu@grenoble-inp.fr: Elia Pinto gitter.spi...@gmail.com writes: @@ -1059,13 +1059,17 @@ cmd_summary() { while read mod_src mod_dst sha1_src sha1_dst status sm_path do

[PATCHv2 10/19] git-submodule.sh: convert test -a/-o to and ||

2014-05-21 Thread Elia Pinto
The interaction with unary operators and operator precedence for and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. --- This is version 2 of the patch to