Re: [PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Junio C Hamano
On Wed, Apr 20, 2016 at 12:56 PM, Ramsay Jones wrote: >>> +void curl_dump(const char *text, unsigned char *ptr, size_t size, char >>> nohex) >>> +{ >>> +size_t i; >>> +size_t w; > > As I said in a previous email, curl_dump() should be marked > static here (and remove the declaration from

Re: [PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Ramsay Jones
On 20/04/16 19:53, Junio C Hamano wrote: > Elia Pinto writes: > >> Implements the GIT_TRACE_CURL environment variable to allow a > > s/Implements/Implement/; speak as if you are giving an order to the > codebase to "be like so". > >> greater degree of detail of GIT_CURL_VERBOSE, in particular

Re: [PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Junio C Hamano
Elia Pinto writes: > Implements the GIT_TRACE_CURL environment variable to allow a s/Implements/Implement/; speak as if you are giving an order to the codebase to "be like so". > greater degree of detail of GIT_CURL_VERBOSE, in particular > the complete transport header and all the data payload

[PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable

2016-04-20 Thread Elia Pinto
Implements the GIT_TRACE_CURL environment variable to allow a greater degree of detail of GIT_CURL_VERBOSE, in particular the complete transport header and all the data payload exchanged. It might be useful if a particular situation could require a more thorough debugging analysis. Helped-by: Tors