On 20/04/16 19:53, Junio C Hamano wrote: > Elia Pinto <gitter.spi...@gmail.com> writes: > >> Implements the GIT_TRACE_CURL environment variable to allow a > > s/Implements/Implement/; speak as if you are giving an order to the > codebase to "be like so". > >> greater degree of detail of GIT_CURL_VERBOSE, in particular >> the complete transport header and all the data payload exchanged. >> It might be useful if a particular situation could require a more >> thorough debugging analysis. >> >> Helped-by: Torsten Bögershausen <tbo...@web.de> >> Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com> >> Helped-by: Junio C Hamano <gits...@pobox.com> >> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> >> Helped-by: Jeff King <p...@peff.net> >> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> >> --- >> http.c | 101 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- >> http.h | 6 ++++ >> 2 files changed, 106 insertions(+), 1 deletion(-) >> >> diff --git a/http.c b/http.c >> index 4304b80..507c386 100644 >> --- a/http.c >> +++ b/http.c >> @@ -11,6 +11,7 @@ >> #include "gettext.h" >> #include "transport.h" >> >> +static struct trace_key trace_curl = TRACE_KEY_INIT(CURL); >> #if LIBCURL_VERSION_NUM >= 0x070a08 >> long int git_curl_ipresolve = CURL_IPRESOLVE_WHATEVER; >> #else >> @@ -464,6 +465,100 @@ static void set_curl_keepalive(CURL *c) >> } >> #endif >> >> + > > No need for this extra blank line. > >> +void curl_dump(const char *text, unsigned char *ptr, size_t size, char >> nohex) >> +{ >> + size_t i; >> + size_t w;
As I said in a previous email, curl_dump() should be marked static here (and remove the declaration from http.h). Unless, of course, there are plans for future use/calls being added? ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html