Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-12 Thread Junio C Hamano
Stefan Beller writes: > $ git send-email 00* --cc=list --cc=bmwill --cc=duy --to=jch > -cover-letter.patch > ... > (mbox) Adding cc: Stefan Beller from line 'From: > Stefan Beller ' > > From: Stefan Beller > To: gits...@pobox.com > Cc: git@vger.kernel.org, > bmw...@google.com, > pclo...@gma

Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-12 Thread Stefan Beller
On Sat, Dec 10, 2016 at 1:13 AM, Jeff King wrote: > On Fri, Dec 09, 2016 at 12:34:49PM -0800, Stefan Beller wrote: > >> My first perl contribution to Git. :) > > Yes, I have some style suggestions below. :) > >> Marked as RFC to gauge general interest before writing tests and >> documentation. > >

Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-10 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Dec 9, 2016 at 3:52 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> So you are suggesting to >>> * have the check later in the game (e.g. just after asking >>>"Send this email? ([y]es|[n]o|[q]uit|[a]ll): " as then other information >>> such as add

Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-10 Thread Jeff King
On Fri, Dec 09, 2016 at 12:34:49PM -0800, Stefan Beller wrote: > My first perl contribution to Git. :) Yes, I have some style suggestions below. :) > Marked as RFC to gauge general interest before writing tests and > documentation. It's hard to evaluate without seeing an example of what you'd a

Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-09 Thread Stefan Beller
On Fri, Dec 9, 2016 at 3:52 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> So you are suggesting to >> * have the check later in the game (e.g. just after asking >>"Send this email? ([y]es|[n]o|[q]uit|[a]ll): " as then other information >> such as additional @to @cc are available. >

Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-09 Thread Junio C Hamano
Stefan Beller writes: > So you are suggesting to > * have the check later in the game (e.g. just after asking >"Send this email? ([y]es|[n]o|[q]uit|[a]ll): " as then other information > such as additional @to @cc are available. Yeah, probably before the loop starts asking that question for

Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-09 Thread Stefan Beller
On Fri, Dec 9, 2016 at 2:36 PM, Junio C Hamano wrote: > > I doubt that this is the best place to call this hook, because the > called hook does not have access to information that may help it > make a better decision. As the commit message may elude, I chose this place as it would be sufficient f

Re: [RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-09 Thread Junio C Hamano
Stefan Beller writes: > This custom hook could be used to prevent sending out e.g. patches > with change ids or other information that upstream doesn't like to see > or is not supposed to see. > > Signed-off-by: Stefan Beller > --- > > My first perl contribution to Git. :) > > Marked as RFC to g

[RFC PATCH] send-email: allow a custom hook to prevent sending email

2016-12-09 Thread Stefan Beller
This custom hook could be used to prevent sending out e.g. patches with change ids or other information that upstream doesn't like to see or is not supposed to see. Signed-off-by: Stefan Beller --- My first perl contribution to Git. :) Marked as RFC to gauge general interest before writing test