Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-20 Thread Felipe Contreras
On Tue, Nov 20, 2012 at 8:56 AM, Krzysztof Mazur krzys...@podlesie.net wrote: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -925,8 +925,11 @@ sub quote_subject { sub sanitize_address { my ($recipient) = @_; + my $local_part_regexp = qr/[^\s@]+/; + my

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-20 Thread Andreas Ericsson
On 11/20/2012 11:28 AM, Felipe Contreras wrote: On Tue, Nov 20, 2012 at 8:56 AM, Krzysztof Mazur krzys...@podlesie.net wrote: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -925,8 +925,11 @@ sub quote_subject { sub sanitize_address { my ($recipient) = @_; + my

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-20 Thread Krzysztof Mazur
On Tue, Nov 20, 2012 at 11:28:39AM +0100, Felipe Contreras wrote: On Tue, Nov 20, 2012 at 8:56 AM, Krzysztof Mazur krzys...@podlesie.net wrote: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -925,8 +925,11 @@ sub quote_subject { sub sanitize_address { my

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-20 Thread Krzysztof Mazur
On Tue, Nov 20, 2012 at 08:58:20PM +0100, Andreas Schwab wrote: How about s/(.*?[^]*).*$/$1/? That will still fail on foo@bar foo@bar, but you'll need a full rfc822 parser to handle the general case anyway. That will fail also on something foo@bar. I think it's good compromise between

Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Felipe Balbi
Hi guys, for whatever reason my git has started acting up with sta...@vger.kernel.org addresses. It doesn't manage to extract a valid adress from the string: Cc: sta...@vger.kernel.org # v3.4 v3.5 v3.6 Removing the comment at the end of the line makes things work again. I do remember, however,

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Krzysztof Mazur
On Mon, Nov 19, 2012 at 11:57:47AM +0200, Felipe Balbi wrote: Hi guys, for whatever reason my git has started acting up with sta...@vger.kernel.org addresses. It doesn't manage to extract a valid adress from the string: Cc: sta...@vger.kernel.org # v3.4 v3.5 v3.6 Removing the comment

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Felipe Balbi
Hi, On Mon, Nov 19, 2012 at 04:18:45PM +0100, Krzysztof Mazur wrote: On Mon, Nov 19, 2012 at 11:57:47AM +0200, Felipe Balbi wrote: Hi guys, for whatever reason my git has started acting up with sta...@vger.kernel.org addresses. It doesn't manage to extract a valid adress from the

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Junio C Hamano
Krzysztof Mazur krzys...@podlesie.net writes: On Mon, Nov 19, 2012 at 11:57:47AM +0200, Felipe Balbi wrote: Hi guys, for whatever reason my git has started acting up with sta...@vger.kernel.org addresses. It doesn't manage to extract a valid adress from the string: Cc:

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Felipe Contreras
On Mon, Nov 19, 2012 at 8:27 PM, Junio C Hamano gits...@pobox.com wrote: Krzysztof Mazur krzys...@podlesie.net writes: On Mon, Nov 19, 2012 at 11:57:47AM +0200, Felipe Balbi wrote: Hi guys, for whatever reason my git has started acting up with sta...@vger.kernel.org addresses. It doesn't

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Krzysztof Mazur
On Mon, Nov 19, 2012 at 11:27:45AM -0800, Junio C Hamano wrote: Given that the problematic line Stable Kernel Maintainance Track sta...@vger.kernel.org # vX.Y is not even a valid e-mail address, doesn't this new logic belong to sanitize_address() conceptually? Yes, it's much better

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: On Mon, Nov 19, 2012 at 11:58 PM, Krzysztof Mazur krzys...@podlesie.net wrote: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -924,6 +924,10 @@ sub quote_subject { # use the simplest quoting being able to handle the recipient

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Junio C Hamano
Krzysztof Mazur krzys...@podlesie.net writes: On Mon, Nov 19, 2012 at 11:27:45AM -0800, Junio C Hamano wrote: Given that the problematic line Stable Kernel Maintainance Track sta...@vger.kernel.org # vX.Y is not even a valid e-mail address, doesn't this new logic belong to

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Krzysztof Mazur
On Mon, Nov 19, 2012 at 04:00:09PM -0800, Junio C Hamano wrote: Krzysztof Mazur krzys...@podlesie.net writes: On Mon, Nov 19, 2012 at 11:27:45AM -0800, Junio C Hamano wrote: Given that the problematic line Stable Kernel Maintainance Track sta...@vger.kernel.org # vX.Y is not

Re: Failure to extra sta...@vger.kernel.org addresses

2012-11-19 Thread Krzysztof Mazur
On Mon, Nov 19, 2012 at 03:57:36PM -0800, Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: On Mon, Nov 19, 2012 at 11:58 PM, Krzysztof Mazur krzys...@podlesie.net wrote: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -924,6 +924,10 @@ sub