Re: Git.pm with recent File::Temp fail

2013-04-29 Thread Junio C Hamano
Here is what I'll queue. Thanks for the help, all of you. -- 8 -- From: H. Merijn Brand h.m.br...@xs4all.nl Subject: Git.pm: call tempfile from File::Temp as a regular function We call File::Temp's tempfile function as a class method, but it was never designed to be called this way. Older

Re: Git.pm with recent File::Temp fail

2013-04-29 Thread H.Merijn Brand
On Mon, 29 Apr 2013 01:18:18 -0700, Junio C Hamano gits...@pobox.com wrote: Here is what I'll queue. Thanks for the help, all of you. Thank you. I will keep this conversation as a guide for possible next patches -- 8 -- From: H. Merijn Brand h.m.br...@xs4all.nl Subject: Git.pm: call

Re: Git.pm with recent File::Temp fail

2013-04-28 Thread H.Merijn Brand
: [PATCH] Git.pm with recent File::Temp fail MIME-Version: 1.0 Content-Type: multipart/mixed; boundary=1.8.2.1 This is a multi-part message in MIME format. --1.8.2.1 Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: 8bit git-1.8.2{,.1,.2}, perl

Re: Git.pm with recent File::Temp fail

2013-04-28 Thread Jeff King
2001 From: H.Merijn Brand - Tux h.m.br...@xs4all.nl Date: Sun, 28 Apr 2013 11:03:15 +0200 Subject: [PATCH] Git.pm with recent File::Temp fail Should be your actual email header, not just in the body of the message. git-1.8.2{,.1,.2}, perl-5.16.3, File::Temp-0.23 Without patch: $ git svn

Re: Git.pm with recent File::Temp fail

2013-04-28 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sun, Apr 28, 2013 at 11:09:33AM +0200, H.Merijn Brand wrote: Still failing in 1.8.2.2 Short fix: --8--- diff --git a/perl/Git.pm b/perl/Git.pm index dc48159..7a252ef 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -1265,7 +1265,7 @@ sub _temp_cache {

Re: Git.pm with recent File::Temp fail

2013-04-28 Thread H.Merijn Brand
On Sun, 28 Apr 2013 20:59:16 -0700, Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: On Sun, Apr 28, 2013 at 11:09:33AM +0200, H.Merijn Brand wrote: Still failing in 1.8.2.2 Short fix: --8--- diff --git a/perl/Git.pm b/perl/Git.pm index dc48159..7a252ef

Re: Git.pm with recent File::Temp fail

2013-04-28 Thread Junio C Hamano
H.Merijn Brand h.m.br...@xs4all.nl writes: I don't need any credits. I just want git to work from scratch :) The sign-off procedure is not about giving credits to you. It is to protect us from others (e.g. your employer) by having a record that you claimed that you had the authority to give us

Re: Git.pm with recent File::Temp fail

2013-04-08 Thread H.Merijn Brand
On Sat, 23 Mar 2013 16:32:47 +, Ben Walton bdwal...@gmail.com wrote: Hello, Still failing in 1.8.2.1 On Fri, Mar 22, 2013 at 7:57 PM, H.Merijn Brand h.m.br...@xs4all.nl wrote: git-1.8.2, perl-5.16.3, File::Temp-0.23 Without patch: $ git svn fetch 'tempfile' can't be called as

Git.pm with recent File::Temp fail

2013-03-22 Thread H.Merijn Brand
git-1.8.2, perl-5.16.3, File::Temp-0.23 Without patch: $ git svn fetch 'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117. After patch: $ git svn fetch M t/06virtual.t r15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e