Fwd: Question: .idx without .pack causes performance issues?

2015-11-11 Thread Thomas Berg
Hi all, (re-sending because my first e-mail was rejected due to html formatting) While debugging a git fetch performance problem on Windows I came across this thread. The problem in our case was also caused by orphaned .idx files. On Tue, Jul 21, 2015 at 9:15 PM, Junio C Hamano

Re: Question: .idx without .pack causes performance issues?

2015-08-07 Thread Doug Kelly
On Mon, Aug 3, 2015 at 8:27 PM, Junio C Hamano gits...@pobox.com wrote: Doug Kelly dougk@gmail.com writes: Here's a change to prune.c that at least addresses the issue by removing .idx files without an associated pack, but it's by no means pretty. If anyone has any feedback before I

Re: Question: .idx without .pack causes performance issues?

2015-08-03 Thread Junio C Hamano
Doug Kelly dougk@gmail.com writes: Here's a change to prune.c that at least addresses the issue by removing .idx files without an associated pack, but it's by no means pretty. If anyone has any feedback before I turn this into a formal patch, it's more than welcome! I'd hesitate to see

Re: Question: .idx without .pack causes performance issues?

2015-08-03 Thread Doug Kelly
On Tue, Jul 21, 2015 at 4:37 PM, Doug Kelly dougk@gmail.com wrote: On Tue, Jul 21, 2015 at 3:48 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: While I still think that it is more important to prevent such a situation from occurring in the first place,

Question: .idx without .pack causes performance issues?

2015-07-21 Thread Doug Kelly
Hi all, I just wanted to relay an issue we've seen before at my day job (and it just recently cropped up again). When moving users from Git for Windows 1.8.3 to 1.9.5, we found a few users started having operations take an excruciatingly long amount of time. At some point, we traced the issue

Re: Question: .idx without .pack causes performance issues?

2015-07-21 Thread Junio C Hamano
Doug Kelly dougk@gmail.com writes: I just wanted to relay an issue we've seen before at my day job (and it just recently cropped up again). When moving users from Git for Windows 1.8.3 to 1.9.5, we found a few users started having operations take an excruciatingly long amount of time.

Re: Question: .idx without .pack causes performance issues?

2015-07-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: I however do not think that we mark the in-core structure that corresponds to an open .idx file in any way when such a failure happens. If we really cared enough, we could do so, saying we know there is .idx file, but do not bother looking at it

Re: Question: .idx without .pack causes performance issues?

2015-07-21 Thread Doug Kelly
On Tue, Jul 21, 2015 at 1:57 PM, Junio C Hamano gits...@pobox.com wrote: I wouldn't be surprised if such a configuration to have leftover .idx files that lack .pack affected performance, but I think you really have to work on getting into such a situation (unless your operating system is very

Re: Question: .idx without .pack causes performance issues?

2015-07-21 Thread Doug Kelly
On Tue, Jul 21, 2015 at 3:48 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: While I still think that it is more important to prevent such a situation from occurring in the first place, ignoring .idx that lack corresponding .pack should be fairly simple,

Re: Question: .idx without .pack causes performance issues?

2015-07-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: While I still think that it is more important to prevent such a situation from occurring in the first place, ignoring .idx that lack corresponding .pack should be fairly simple, perhaps like this. ... Sorry for the noise, but this patch is worthless.