Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-05-03 Thread James Denholm
Matthew Ogilvie mmogilvi_...@miniinfo.net wrote: On Sun, Apr 27, 2014 at 12:35:13PM +1000, James Denholm wrote: Jeff King p...@peff.net wrote: Agreed. It also doesn't help that when subtree patches are proposed (especially new features instead of obvious bugs), there often seems to be little

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-05-03 Thread Felipe Contreras
James Denholm wrote: Matthew Ogilvie mmogilvi_...@miniinfo.net wrote: On Sun, Apr 27, 2014 at 12:35:13PM +1000, James Denholm wrote: Jeff King p...@peff.net wrote: Agreed. It also doesn't help that when subtree patches are proposed (especially new features instead of obvious bugs), there

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-05-03 Thread James Denholm
On 4 May 2014 05:22:48 GMT+10:00, Felipe Contreras felipe.contre...@gmail.com wrote: I think you should take a look at the Makefile of contrib/remote-helpers. I bet something simple like that would work just fine for subtree. The current makefile is simple enough, just quirky and likes to be a

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-04-29 Thread Matthew Ogilvie
On Sun, Apr 27, 2014 at 12:35:13PM +1000, James Denholm wrote: Jeff King p...@peff.net wrote: I think the problem is that contrib/subtree does not really have an active dedicated area maintainer. Yeah, I can see how that might become a bit of a problem. I was actually thinking of doing a

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-04-26 Thread Jeff King
On Sat, Apr 26, 2014 at 02:56:15PM +1000, nod.h...@gmail.com wrote: contrib/subtree/Makefile is a shambles in regards to it's consistency with other makefiles, which makes subtree overly painful to include in build scripts. Two major issues are present: Firstly, calls to git itself

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-04-26 Thread James Denholm
Jeff King p...@peff.net wrote: I think the problem is that contrib/subtree does not really have an active dedicated area maintainer. Yeah, I can see how that might become a bit of a problem. I was actually thinking of doing a bit of work on subtree beyond this specific patch, so hopefully that

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-04-26 Thread Jeff King
On Sun, Apr 27, 2014 at 12:35:13PM +1000, James Denholm wrote: Do we even make [subproject and mainline] anymore? It looks like they are part of the tests, but the whole test script runs inside its own trash directory. subproject and mainline are actually made in contrib/subtree, but

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-04-26 Thread James Denholm
Jeff King p...@peff.net wrote: On Sun, Apr 27, 2014 at 12:35:13PM +1000, James Denholm wrote: Do we even make [subproject and mainline] anymore? It looks like they are part of the tests, but the whole test script runs inside its own trash directory. subproject and mainline are actually made

Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

2014-04-25 Thread nod . helm
On 24 Apr 2014 11:52, nod.h...@gmail.com wrote: From: James Denholm nod.h...@gmail.com contrib/subtree/Makefile is a shambles in regards to it's consistency with other makefiles, which makes subtree overly painful to include in build scripts. Two major issues are present: Firstly,