Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Hi Junio, On Mon, 4 Apr 2016, Junio C Hamano wrote: > Johannes Sixt writes: > > > Although I am convinced that the change is not necessary for > > correctness, I can buy the justification that we should produce forward > > slashes for consistency. There are a number of occasions

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Johannes Sixt writes: > Although I am convinced that the change is not necessary for > correctness, I can buy the justification that we should produce forward > slashes for consistency. There are a number of occasions where we > present paths to the user, and we do show

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Am 29.03.2016 um 22:05 schrieb Junio C Hamano: > Johannes Sixt writes: > >> This part of your 45bf3297 (t1300: fix the new --show-origin tests on >> Windows) >> >> @@ -1205,6 +1205,9 @@ test_expect_success POSIXPERM,PERL 'preserves existing >> per >>"die q(badrename)

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Am 30.03.2016 um 07:52 schrieb Johannes Sixt: Am 29.03.2016 um 21:18 schrieb Johannes Sixt: It does pass. The reason is that pwd -W generates forward slashes. It just occurred to me that we might be observing a difference in behavior of pwd -W between the modern MSYS2 bash and the old MSYS1

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Am 29.03.2016 um 21:18 schrieb Johannes Sixt: Am 28.03.2016 um 17:14 schrieb Johannes Schindelin: The problem with your patch is that it does not account for backslashes in paths resulting in quoting. I am afraid that your patch will most likely *not* let the tests pass in Git for Windows SDK,

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Johannes Sixt writes: > This part of your 45bf3297 (t1300: fix the new --show-origin tests on > Windows) > > @@ -1205,6 +1205,9 @@ test_expect_success POSIXPERM,PERL 'preserves existing > per > "die q(badrename) if ((stat(q(.git/config)))[2] & 0) != 0600" > ' > >

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Am 28.03.2016 um 17:14 schrieb Johannes Schindelin: > Hi Hannes, > > On Mon, 28 Mar 2016, Johannes Sixt wrote: > >> A change like this whould have been preferable: >> [...] > > The problem with your patch is that it does not account for backslashes in > paths resulting in quoting. I am afraid

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Hi Hannes, On Mon, 28 Mar 2016, Johannes Sixt wrote: > A change like this whould have been preferable: > [...] The problem with your patch is that it does not account for backslashes in paths resulting in quoting. I am afraid that your patch will most likely *not* let the tests pass in Git for

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Am 22.03.2016 um 18:42 schrieb Johannes Schindelin: > On Windows, the backslash is the native directory separator, but all > supported Windows versions also accept the forward slash in most > circumstances. > > Our tests expect forward slashes. > > Relative paths are generated by Git using

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Johannes Schindelin writes: >> > diff --git a/path.c b/path.c >> > index 8b7e168..969b494 100644 >> > --- a/path.c >> > +++ b/path.c >> > @@ -584,6 +584,9 @@ char *expand_user_path(const char *path) >> >if (!home) >> >

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Hi Junio, On Tue, 22 Mar 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Windows, the backslash is the native directory separator, but > > all supported Windows versions also accept the forward slash in > > most circumstances. > > > > Our tests

Re: [PATCH 1/4] config --show-origin: report paths with forward slashes

Johannes Schindelin writes: > On Windows, the backslash is the native directory separator, but > all supported Windows versions also accept the forward slash in > most circumstances. > > Our tests expect forward slashes. > > Relative paths are generated by Git using