Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On 11/2/2017 3:32 PM, Jonathan Tan wrote: On Thu, 2 Nov 2017 17:50:11 + Jeff Hostetler wrote: + if (skip_prefix(v0, "oid=", )) { + filter_options->choice = LOFC_SPARSE_OID; + if (!get_oid_with_context(v1,

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On Mon, 6 Nov 2017 12:51:52 -0500 Jeff Hostetler wrote: > Jonathan and I were talking off-list about the performance > effects of inspecting the pathnames to identify the ".git*" > special files. I added it in my first draft back in the spring, > thinking that even if you

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On 11/2/2017 1:50 PM, Jeff Hostetler wrote: From: Jeff Hostetler Create traverse_commit_list_filtered() and add filtering interface to allow certain objects to be omitted from the traversal. ... diff --git a/list-objects-filter.c b/list-objects-filter.c new file mode

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On 11/3/2017 7:54 AM, Johannes Schindelin wrote: Hi Jonathan, On Thu, 2 Nov 2017, Jonathan Tan wrote: On Thu, 2 Nov 2017 17:50:11 + Jeff Hostetler wrote: +int parse_list_objects_filter(struct list_objects_filter_options *filter_options, +

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

Hi Jonathan, On Thu, 2 Nov 2017, Jonathan Tan wrote: > On Thu, 2 Nov 2017 17:50:11 + > Jeff Hostetler wrote: > > > +int parse_list_objects_filter(struct list_objects_filter_options > > *filter_options, > > + const char *arg) > > Returning

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On Thu, 2 Nov 2017 17:50:11 + Jeff Hostetler wrote: > +int parse_list_objects_filter(struct list_objects_filter_options > *filter_options, > + const char *arg) Returning void is fine, I think. It seems that all your code paths either