Re: [PATCH v4 00/19] Introduce an internal API to interact with the fsck machinery

2015-02-04 Thread Johannes Schindelin
Hi Junio, On 2015-02-04 04:50, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: [fsck level] missingAuthor = error , which looks funny. level is a constant, so it seems superfluous. Yes, it is superfluous, but is one way to avoid the ambiguity with

Re: [PATCH v4 00/19] Introduce an internal API to interact with the fsck machinery

2015-02-03 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: [fsck level] missingAuthor = error , which looks funny. level is a constant, so it seems superfluous. Yes, it is superfluous, but is one way to avoid the ambiguity with skiplist. Structuring it like this would not be so bad,

Re: [PATCH v4 00/19] Introduce an internal API to interact with the fsck machinery

2015-02-03 Thread Michael Haggerty
On 02/02/2015 05:48 PM, Johannes Schindelin wrote: On 2015-02-02 13:43, Michael Haggerty wrote: On 02/02/2015 12:41 PM, Johannes Schindelin wrote: Hi all (in particular Junio), On 2015-01-31 22:04, Johannes Schindelin wrote: [...] switch to fsck.severity to address Michael's concerns that

Re: [PATCH v4 00/19] Introduce an internal API to interact with the fsck machinery

2015-02-03 Thread Johannes Schindelin
Hi Michael, On 2015-02-03 16:11, Michael Haggerty wrote: On 02/02/2015 05:48 PM, Johannes Schindelin wrote: On 2015-02-02 13:43, Michael Haggerty wrote: On 02/02/2015 12:41 PM, Johannes Schindelin wrote: Hi all (in particular Junio), On 2015-01-31 22:04, Johannes Schindelin wrote: [...]

Re: [PATCH v4 00/19] Introduce an internal API to interact with the fsck machinery

2015-02-02 Thread Michael Haggerty
On 02/02/2015 12:41 PM, Johannes Schindelin wrote: Hi all (in particular Junio), On 2015-01-31 22:04, Johannes Schindelin wrote: [...] switch to fsck.severity to address Michael's concerns that letting fsck.(error|warn|ignore)'s comma-separated lists possibly overriding each other

Re: [PATCH v4 00/19] Introduce an internal API to interact with the fsck machinery

2015-02-02 Thread Johannes Schindelin
Hi all (in particular Junio), On 2015-01-31 22:04, Johannes Schindelin wrote: [...] switch to fsck.severity to address Michael's concerns that letting fsck.(error|warn|ignore)'s comma-separated lists possibly overriding each other partially; Having participated in the CodingStyle thread, I

Re: [PATCH v4 00/19] Introduce an internal API to interact with the fsck machinery

2015-02-02 Thread Johannes Schindelin
Hi Michael, On 2015-02-02 13:43, Michael Haggerty wrote: On 02/02/2015 12:41 PM, Johannes Schindelin wrote: Hi all (in particular Junio), On 2015-01-31 22:04, Johannes Schindelin wrote: [...] switch to fsck.severity to address Michael's concerns that letting fsck.(error|warn|ignore)'s