Re: Test failures in t4034

2012-09-02 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: Yes, there was a net increase in the line count when I introduced die(), but the main program flow was less cluttered by error handling. The net result looked much better, so I thought it was worth it. What may not be too obvious, however, is

Re: Test failures in t4034

2012-09-01 Thread Ramsay Jones
Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: [snip] diff --git a/test-regex.c b/test-regex.c new file mode 100644 index 000..9259985 --- /dev/null +++ b/test-regex.c @@ -0,0 +1,35 @@ +#include stdlib.h +#include stdio.h +#include stdarg.h +#include

Re: Test failures in t4034

2012-08-21 Thread Ramsay Jones
this may not be relevent; does OS X use glibc? (I didn't think so, but ...) I sent some patches to the list which may be helpful. I can't get to gmane to look up a reference, but you need to search for: [RFC/PATCH] userdiff.c: Avoid old glibc regex bug causing t4034-*.sh test failures sent

Re: Test failures in t4034

2012-08-21 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: I think that, after some testing, this (or something like it) is the best that we can do. What do you think? ATB, Ramsay Jones -- 8 -- Subject: [PATCH] test-regex: Add a test to check for a bug in the regex routines Signed-off-by: Ramsay

Re: Test failures in t4034

2012-08-19 Thread Junio C Hamano
Brian Gernhardt br...@gernhardtsoftware.com writes: I've been getting a couple of test failures and finally had the time to track them down. t4034-diff-words fails tests 22 diff driver 'bibtex' and 26 diff driver 'html'. Bisecting shows that the file started giving me errors in commit

Re: Test failures in t4034

2012-08-19 Thread Junio C Hamano
Brian Gernhardt mister.r...@gmail.com writes: I wonder if there is something non-portable about the bibtex filter? (The HTML filter as well, since that errors on my machine too.) Yeah, that I didn't think of, but is a possibility (part of (1) above). The HTML one is [^= \t]+ and the Bibtex

Re: Test failures in t4034

2012-08-19 Thread Johannes Sixt
Am 19.08.2012 16:50, schrieb Ramsay Jones: Brian Gernhardt wrote: I've been getting a couple of test failures and finally had the time to track them down. t4034-diff-words fails tests 22 diff driver 'bibtex' and 26 diff driver 'html'. Bisecting shows that the file started giving me errors

Test failures in t4034

2012-08-18 Thread Brian Gernhardt
I've been getting a couple of test failures and finally had the time to track them down. t4034-diff-words fails tests 22 diff driver 'bibtex' and 26 diff driver 'html'. Bisecting shows that the file started giving me errors in commit 8d96e72 t4034: bulk verify builtin word regex sanity, which