Re: [PATCH v2 5/6] clone: fix hostname parsing when guessing dir

2015-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2015 at 10:42:21AM -0700, Junio C Hamano wrote: Patrick Steinhardt p...@pks.im writes: We fail to guess a sensible directory name for a newly cloned repository when the path component of the URL is empty. E.g. cloning a repository 'ssh://user:passw...@example.com/' we

Re: [PATCH v2 4/6] connect: move error check to caller of parse_connect_url

2015-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2015 at 04:32:13PM -0400, Eric Sunshine wrote: On Wed, Jul 29, 2015 at 11:51 AM, Patrick Steinhardt p...@pks.im wrote: parse_connect_url() checks if the path component of the URL is empty and if so causes the program to die. As the function is to be used at other call sites

[PATCH v7 11/11] tag.c: implement '--merged' and '--no-merged' options

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Using 'ref-filter' APIs implement the '--merged' and '--no-merged' options into 'tag.c'. The '--merged' option lets the user to only list tags merged into the named commit. The '--no-merged' option lets the user to only list tags not merged into the named

[PATCH v7 08/11] tag.c: use 'ref-filter' data structures

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Make 'tag.c' use 'ref-filter' data structures and make changes to support the new data structures. This is a part of the process of porting 'tag.c' to use 'ref-filter' APIs. This is a temporary step before porting 'tag.c' to use 'ref-filter' completely.

[PATCH v7 0/11] port tag.c to use ref-filter APIs

2015-07-30 Thread Karthik Nayak
This is part of my GSoC project to unify git tag -l, git branch -l, git for-each-ref. This patch series is continued from: Git (next) https://github.com/git/git/commit/bf5418f49ff0cebc6e5ce04ad1417e1a47c81b61 Version 6 can be found here:

[PATCH v7 01/11] ref-filter: introduce 'ref_formatting_state'

2015-07-30 Thread Karthik Nayak
Introduce 'ref_formatting_state' structure to hold values of modifier atoms which help only in formatting. This will eventually be used by atoms like `padright` which will be introduced in a later patch. Helped-by: Junio C Hamano gits...@pobox.com Mentored-by: Christian Couder

[PATCH v7 06/11] ref-filter: add support to sort by version

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Add support to sort by version using the v:refname and version:refname option. This is achieved by using the 'versioncmp()' function as the comparing function for qsort. This option is included to support sorting by versions in `git tag -l` which will

[PATCH v7 10/11] tag.c: implement '--format' option

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Implement the '--format' option provided by 'ref-filter'. This lets the user list tags as per desired format similar to the implementation in 'git for-each-ref'. Add tests and documentation for the same. Mentored-by: Christian Couder

[PATCH v7 09/11] tag.c: use 'ref-filter' APIs

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Make 'tag.c' use 'ref-filter' APIs for iterating through refs, sorting and printing of refs. This removes most of the code used in 'tag.c' replacing it with calls to the 'ref-filter' library. Make 'tag.c' use the 'filter_refs()' function provided by

[PATCH v7 02/11] ref-filter: make `color` use `ref_formatting_state`

2015-07-30 Thread Karthik Nayak
Convert the 'color' atom to behave as a modifier atom and make it use 'ref_formatting_state' which was introduced in the previous patch. Helped-by: Junio C Hamano gits...@pobox.com Mentored-by: Christian Couder christian.cou...@gmail.com Mentored-by: Matthieu Moy matthieu@grenoble-inp.fr

[PATCH v7 05/11] ref-filter: support printing N lines from tag annotation

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com In 'tag.c' we can print N lines from the annotation of the tag using the '-nnum' option. Copy code from 'tag.c' to 'ref-filter' and modify 'ref-filter' to support printing of N lines from the annotation of tags. Mentored-by: Christian Couder

Re: [PATCH] git-am: flag suspiciously old or futuristic commits

2015-07-30 Thread Paul Gortmaker
On 2015-07-30 12:35 AM, Jacob Keller wrote: On Wed, Jul 29, 2015 at 3:20 PM, Stefan Beller sbel...@google.com wrote: On Wed, Jul 29, 2015 at 3:01 PM, Paul Gortmaker paul.gortma...@windriver.com wrote: The linux kernel repository has some commits in it with dates from the year 1970 and also

[PATCH] pull.sh: quote $upload_pack when passing it to git-fetch

2015-07-30 Thread Matthieu Moy
The previous code broke for example git pull --upload-pack 'echo --foo' Reported-by: Joey Hess i...@joeyh.name Fix-suggested-by: Junio C Hamano gits...@pobox.com Signed-off-by: Matthieu Moy matthieu@imag.fr --- Junio wrote: ${upload_pack+$upload_pack} or something. Indeed, we need to

Re: [PATCH 2/2] refs: support negative transfer.hideRefs

2015-07-30 Thread Eric Sunshine
On Tue, Jul 28, 2015 at 3:59 PM, Jeff King p...@peff.net wrote: If you hide a hierarchy of refs using the transfer.hideRefs config, there is no way to later override that config to unhide it. This patch implements a negative hide which causes matches to immediately be marked as unhidden, even

I have decided to donate my funds to you for charity project

2015-07-30 Thread info
-- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pull.sh: quote $upload_pack when passing it to git-fetch

2015-07-30 Thread Junio C Hamano
Matthieu Moy matthieu@imag.fr writes: The previous code broke for example git pull --upload-pack 'echo --foo' Reported-by: Joey Hess i...@joeyh.name Fix-suggested-by: Junio C Hamano gits...@pobox.com Signed-off-by: Matthieu Moy matthieu@imag.fr --- Junio wrote:

Re: Confused about sparse vs untracked-cache

2015-07-30 Thread David Turner
On Thu, 2015-07-30 at 21:09 +0700, Duy Nguyen wrote: On Thu, Jul 30, 2015 at 9:32 AM, David Turner dtur...@twopensource.com wrote: I'm looking at dir.c, and there's a bit I'm confused about: prep_exclude() says: /* * .. and .gitignore does

Re: [PATCH v2 6/6] clone: add tests for cloning with empty path

2015-07-30 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Wed, Jul 29, 2015 at 11:51 AM, Patrick Steinhardt p...@pks.im wrote: Test behavior of `git clone` when working with an empty path component. This may be the case when cloning a file system's root directory or from a remote server's root.

Re: [PATCH 2/2] refs: support negative transfer.hideRefs

2015-07-30 Thread Jeff King
On Thu, Jul 30, 2015 at 04:17:35PM -0400, Eric Sunshine wrote: + test_expect_success Override hiding of $configsection.hiderefs ' + test_when_finished test_unconfig $configsection.hiderefs + git config --add $configsection.hiderefs refs/tags +

Re: Confused about sparse vs untracked-cache

2015-07-30 Thread David Turner
On Thu, 2015-07-30 at 19:30 -0400, David Turner wrote: On Thu, 2015-07-30 at 21:09 +0700, Duy Nguyen wrote: On Thu, Jul 30, 2015 at 9:32 AM, David Turner dtur...@twopensource.com wrote: I'm looking at dir.c, and there's a bit I'm confused about: prep_exclude() says:

Re: [PATCH v6 01/10] ref-filter: introduce 'ref_formatting_state'

2015-07-30 Thread Karthik Nayak
On Thu, Jul 30, 2015 at 12:49 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Tuesday, July 28, 2015, Karthik Nayak karthik@gmail.com wrote: Introduce 'ref_formatting' structure to hold values of pseudo atoms which help only in formatting. This will eventually be used by atoms like

git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Joey Hess
In git 2.1.4, I can run: git pull --upload-pack 'echo --foo' This also seems to work in 2.4.6, but in 2.5.0, the option parser does something weird, apparently looking inside the quoted parameter and parsing parameters in there: error: unknown option `foo' usage: git fetch [options] [repository

[PATCH v7 03/11] ref-filter: add option to pad atoms to the right

2015-07-30 Thread Karthik Nayak
Add a new atom padright and support %(padright:X) where X is a number. This will align the succeeding atom or string to the left followed by spaces for a total length of X characters. If X is less than the atom or string length then no padding is done. Add tests and documentation for the same.

[PATCH v7 02/11] ref-filter: make `color` use `ref_formatting_state`

2015-07-30 Thread Karthik Nayak
Convert the 'color' atom to behave as a modifier atom and make it use 'ref_formatting_state' which was introduced in the previous patch. Helped-by: Junio C Hamano gits...@pobox.com Mentored-by: Christian Couder christian.cou...@gmail.com Mentored-by: Matthieu Moy matthieu@grenoble-inp.fr

[PATCH v7 01/11] ref-filter: introduce 'ref_formatting_state'

2015-07-30 Thread Karthik Nayak
Introduce 'ref_formatting_state' structure to hold values of modifier atoms which help only in formatting. This will eventually be used by atoms like `padright` which will be introduced in a later patch. Helped-by: Junio C Hamano gits...@pobox.com Mentored-by: Christian Couder

[PATCH v7 05/11] ref-filter: support printing N lines from tag annotation

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com In 'tag.c' we can print N lines from the annotation of the tag using the '-nnum' option. Copy code from 'tag.c' to 'ref-filter' and modify 'ref-filter' to support printing of N lines from the annotation of tags. Mentored-by: Christian Couder

[PATCH v7 07/11] ref-filter: add option to match literal pattern

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Since 'ref-filter' only has an option to match path names add an option for plain fnmatch pattern-matching. This is to support the pattern matching options which are used in `git tag -l` and `git branch -l` where we can match patterns like `git tag -l

Re: git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Junio C Hamano
On Thu, Jul 30, 2015 at 11:31 AM, Joey Hess i...@joeyh.name wrote: I think this comes down to a lack of quoting where git-pull runs git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6, $@ was passed through to git-fetch, but now there is a $upload_pack which is passed without being

Re: git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Joey Hess
I think this comes down to a lack of quoting where git-pull runs git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6, $@ was passed through to git-fetch, but now there is a $upload_pack which is passed without being quoted. -- see shy jo signature.asc Description: Digital signature

Re: [PATCH v3 2/6] notes: replace pseudorefs with real refs

2015-07-30 Thread Johan Herland
On Wed, Jul 29, 2015 at 6:37 PM, Junio C Hamano gits...@pobox.com wrote: Johan Herland jo...@herland.net writes: On Wed, Jul 29, 2015 at 7:01 AM, Junio C Hamano gits...@pobox.com wrote: Johan Herland jo...@herland.net writes: I believe it is a bad compromise. It complicates the code, and it

Re: [RFC/PATCH 10/11] branch.c: use 'ref-filter' APIs

2015-07-30 Thread Karthik Nayak
On Wed, Jul 29, 2015 at 9:26 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Karthik Nayak karthik@gmail.com writes: On Tue, Jul 28, 2015 at 7:47 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: I'm not sure what's the convention, but I think the test description should give

Re: [RFC/PATCH 10/11] branch.c: use 'ref-filter' APIs

2015-07-30 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: On Wed, Jul 29, 2015 at 9:26 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Karthik Nayak karthik@gmail.com writes: On Tue, Jul 28, 2015 at 7:47 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: I'm not sure what's the convention,

Re: [PATCH] worktree: Correct typo in documentation

2015-07-30 Thread Johan Sageryd
Thanks for the patch. This is already fixed in the 'next' branch by 2e73ab6 (Documentation/git-worktree: fix incorrect reference to file locked, 2015-07-20). You are right; sorry for the noise. I checked only maint and master. /J -- To unsubscribe from this list: send the line unsubscribe git

[PATCH v7 10/11] tag.c: implement '--format' option

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Implement the '--format' option provided by 'ref-filter'. This lets the user list tags as per desired format similar to the implementation in 'git for-each-ref'. Add tests and documentation for the same. Mentored-by: Christian Couder

[PATCH v7 09/11] tag.c: use 'ref-filter' APIs

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Make 'tag.c' use 'ref-filter' APIs for iterating through refs, sorting and printing of refs. This removes most of the code used in 'tag.c' replacing it with calls to the 'ref-filter' library. Make 'tag.c' use the 'filter_refs()' function provided by

[PATCH v7 06/11] ref-filter: add support to sort by version

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Add support to sort by version using the v:refname and version:refname option. This is achieved by using the 'versioncmp()' function as the comparing function for qsort. This option is included to support sorting by versions in `git tag -l` which will

[PATCH v7 03/11] ref-filter: add option to pad atoms to the right

2015-07-30 Thread Karthik Nayak
Add a new atom padright and support %(padright:X) where X is a number. This will align the succeeding atom or string to the left followed by spaces for a total length of X characters. If X is less than the atom or string length then no padding is done. Add tests and documentation for the same.

[PATCH v7 04/11] ref-filter: add option to filter only tags

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Add a functions called 'for_each_tag_ref_fullpath()' to refs.{c,h} which iterates through each tag ref without trimming the path. Add an option in 'filter_refs()' to use 'for_each_tag_ref_fullpath()' and filter refs. This type checking is done by adding

[PATCH v7 08/11] tag.c: use 'ref-filter' data structures

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Make 'tag.c' use 'ref-filter' data structures and make changes to support the new data structures. This is a part of the process of porting 'tag.c' to use 'ref-filter' APIs. This is a temporary step before porting 'tag.c' to use 'ref-filter' completely.

[PATCH v7 11/11] tag.c: implement '--merged' and '--no-merged' options

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Using 'ref-filter' APIs implement the '--merged' and '--no-merged' options into 'tag.c'. The '--merged' option lets the user to only list tags merged into the named commit. The '--no-merged' option lets the user to only list tags not merged into the named

[PATCH v7 07/11] ref-filter: add option to match literal pattern

2015-07-30 Thread Karthik Nayak
From: Karthik Nayak karthik@gmail.com Since 'ref-filter' only has an option to match path names add an option for plain fnmatch pattern-matching. This is to support the pattern matching options which are used in `git tag -l` and `git branch -l` where we can match patterns like `git tag -l

Re: [PATCH v3 2/6] notes: replace pseudorefs with real refs

2015-07-30 Thread Junio C Hamano
Johan Herland jo...@herland.net writes: Actually, the name linked worktree is probably a misnomer. ... Makes sense, although currently, IINM, those multiple $GIT_DIRs must be associated with strictly different branches, which is completely unrelated to the desired notes-merge restriction

Re: [PATCH v2 5/6] clone: fix hostname parsing when guessing dir

2015-07-30 Thread Junio C Hamano
Patrick Steinhardt p...@pks.im writes: Regardless of the issue you are trying to address, we may want to limit that be prepared for and careful with ':' logic in the existing code to the case where the last component does not have any other component before it. That is:

Re: [PATCH v2 5/6] clone: fix hostname parsing when guessing dir

2015-07-30 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Well, but there is the above or we may not ;-) But actually you are right, currently I still have the old logic in place that splits on colons in the path component. Yes. The reason why I suggested the simple route was exactly because I noticed

[GSOC] Update 5: Unification of tag -l, branch -l and for-each-ref

2015-07-30 Thread Karthik Nayak
Hello All, As part of GSoC I'm working on the Unification of 'for-each-ref', 'tag -l' and 'branch -l'. Current Progress: 1. Building ref-filter.{c,h} from for-each-ref. This is the process of creating an initial library for the unification by moving most of the code from for-each-ref to

Re: [GSOC] Update 5: Unification of tag -l, branch -l and for-each-ref

2015-07-30 Thread Karthik Nayak
This is update 6 :D -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 02/11] ref-filter: add 'colornext' atom

2015-07-30 Thread Junio C Hamano
Jacob Keller jacob.kel...@gmail.com writes: On Wed, Jul 29, 2015 at 2:30 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Eric Sunshine sunsh...@sunshineco.com writes: Also, please explain here and in the commit message why this highly specialized colorizer ('colornext'), is needed even

[PATCH] add: remove dead code

2015-07-30 Thread Stefan Beller
Signed-off-by: Stefan Beller sbel...@google.com --- So I was trying to understand how to implement git add .gitmodules as I intend to rewrite git submodules in C. builtin/add.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/builtin/add.c b/builtin/add.c index 4bd98b7..b2a5c57 100644 ---

Re: git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Matthieu Moy
Joey Hess i...@joeyh.name writes: In git 2.1.4, I can run: git pull --upload-pack 'echo --foo' This also seems to work in 2.4.6, but in 2.5.0, the option parser does something weird, apparently looking inside the quoted parameter and parsing parameters in there: error: unknown option `foo'

Re: [PATCH v7 03/11] ref-filter: add option to pad atoms to the right

2015-07-30 Thread Eric Sunshine
On Thu, Jul 30, 2015 at 11:48 AM, Karthik Nayak karthik@gmail.com wrote: Add a new atom padright and support %(padright:X) where X is a number. This will align the succeeding atom or string to the left followed by spaces for a total length of X characters. If X is less than the atom or

Ten more days for your invited paper (see below)

2015-07-30 Thread Olga Nikolova
Dear Professor Our colleagues has just published two very nice web pages with information for the indexing and feedback from our WSEAS conferences and Journals http://www.worldses.org/journals and http://www.wseas.us For example, visit http://www.worldses.org/journals/#feedback The contents

Re: What's cooking in git.git (Jul 2015, #07; Mon, 27)

2015-07-30 Thread Matthieu Moy
brian m. carlson sand...@crustytoothpaste.net writes: On Mon, Jul 27, 2015 at 02:23:04PM -0700, Junio C Hamano wrote: * bc/object-id (2015-06-17) 10 commits . remote.c: use struct object_id in many functions . object-id: use struct object_id in struct object . remote.c: use struct

Re: [PATCH v6 0/10] port tag.c to use ref-filter APIs

2015-07-30 Thread Karthik Nayak
On Thu, Jul 30, 2015 at 3:14 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Junio C Hamano gits...@pobox.com writes: Currently we do not need it to reimplement the canned 'tag -l' format is an OK and sensible justification to stick to the current implementation of %(padright:N), but

Re: [PATCH v6 02/10] ref-filter: add option to pad atoms to the right

2015-07-30 Thread Karthik Nayak
On Thu, Jul 30, 2015 at 12:59 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Tuesday, July 28, 2015, Karthik Nayak karthik@gmail.com wrote: Add a new atom padright and support %(padright:X) where X is a number. This will align the succeeding atom value to the left followed by spaces

Re: [PATCH v6 05/10] ref-filter: add support to sort by version

2015-07-30 Thread Karthik Nayak
On Thu, Jul 30, 2015 at 1:04 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Tuesday, July 28, 2015, Karthik Nayak karthik@gmail.com wrote: Add support to sort by version using the v:refname and version:refname option. This is achieved by using the 'versioncmp()' function as the

Re: [PATCH v6 01/10] ref-filter: introduce 'ref_formatting_state'

2015-07-30 Thread Karthik Nayak
On Thu, Jul 30, 2015 at 1:24 AM, Junio C Hamano gits...@pobox.com wrote: Actually, I think it is wrong to have this function in the first place. It is a sign that the caller is doing too little before calling this function. If the act of printing an atom uses the formatting state that says

Re: [PATCH v6 01/10] ref-filter: introduce 'ref_formatting_state'

2015-07-30 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: If the act of printing an atom uses the formatting state that says next one needs X, then it is responsible to clear that next one needs X part of the state, as it is the one who consumed that state. E.g. if it used to say next one needs to be padded

Re: [PATCH v6 0/10] port tag.c to use ref-filter APIs

2015-07-30 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Currently we do not need it to reimplement the canned 'tag -l' format is an OK and sensible justification to stick to the current implementation of %(padright:N), but we'd need to think if we would want to keep this limited and strange form that

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-30 Thread Karthik Nayak
On Wed, Jul 29, 2015 at 3:19 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Mon, Jul 27, 2015 at 3:27 AM, Karthik Nayak karthik@gmail.com wrote: From: Karthik Nayak karthik@gmail.com Since 'ref-filter' only has an option to match path names add an option for plain fnmatch

Re: [PATCH v2] completion: Add '--edit-todo' to rebase

2015-07-30 Thread SZEDER Gábor
Quoting Thomas Braun thomas.br...@virtuell-zuhause.de: Signed-off-by: Thomas Braun thomas.br...@virtuell-zuhause.de --- John Keeping j...@keeping.me.uk hat am 13. Juli 2015 um 15:11 geschrieben: git-rebase.sh contains: if test $action = edit-todo test $type != interactive

Re: [PATCH v2] completion: Add '--edit-todo' to rebase

2015-07-30 Thread John Keeping
On Thu, Jul 30, 2015 at 01:24:03PM +0200, SZEDER Gábor wrote: Quoting Thomas Braun thomas.br...@virtuell-zuhause.de: Signed-off-by: Thomas Braun thomas.br...@virtuell-zuhause.de --- John Keeping j...@keeping.me.uk hat am 13. Juli 2015 um 15:11 geschrieben: git-rebase.sh contains: