What's cooking in git.git (Aug 2017, #07; Sat, 26)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. As I am preparing to go offline

Re: [PATCH 02/12] load_subtree(): remove unnecessary conditional

On Sat, Aug 26, 2017 at 6:38 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> At this point in the code, len is *always* <= 20. > > This is the kind of log message that makes me unconfortable, as it > lacks "because", and the readers would need

Re: cat-file timing window on Cygwin

On Sun, Aug 27, 2017 at 03:06:31AM +0100, Ramsay Jones wrote: > On 26/08/17 22:11, Adam Dinwoodie wrote: > > On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote: > >> Interesting. I find it a little hard to believe there's so obvious a bug > >> as "fflush(NULL) flushes stdin", but

Re: [GSoC][PATCH v3 0/4] Incremental rewrite of git-submodules

On Sat, Aug 26, 2017 at 12:21 AM, Junio C Hamano wrote: > Thanks. I'll try to queue these before I'll go offline. > > Mentors may want to help the student further in adjusting the patch > series to the more recent codebase; unfortunately the area the GSoC > project touches is

[PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

The static-ness was silently dropped in commit 70428d1a5 ("pkt-line: add packet_write_fmt_gently()", 2016-10-16). As a result, for each call to packet_write_fmt_1, we allocate and leak a buffer. We could keep the strbuf non-static and instead make sure we always release it before returning (but

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

> On 27 Aug 2017, at 21:09, Martin Ågren wrote: > > On 27 August 2017 at 20:21, Lars Schneider wrote: >> >>> On 27 Aug 2017, at 09:37, Martin Ågren wrote: >>> >>> The static-ness was silently dropped in commit

RE: cat-file timing window on Cygwin

> -Original Message- > From: Ramsay Jones > Sent: Sunday, August 27, 2017 11:48 AM > To: Adam Dinwoodie > Cc: Jeff King; git@vger.kernel.org; Johannes Schindelin > Subject: Re: cat-file timing window on Cygwin > > > > On 27/08/17 12:33, Adam Dinwoodie wrote: > > On Sun, Aug 27, 2017 at

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

On Sun, Aug 27, 2017 at 09:09:15PM +0200, Martin Ågren wrote: > On 27 August 2017 at 20:21, Lars Schneider wrote: > > > >> On 27 Aug 2017, at 09:37, Martin Ågren wrote: > >> > >> The static-ness was silently dropped in commit 70428d1a5

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

On 27 August 2017 at 20:21, Lars Schneider wrote: > >> On 27 Aug 2017, at 09:37, Martin Ågren wrote: >> >> The static-ness was silently dropped in commit 70428d1a5 ("pkt-line: add >> packet_write_fmt_gently()", 2016-10-16). As a result, for each

Loan Offer!

Loan Offer at 3%, Feel Free to REPLY back to us for more info.

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

On Sun, Aug 27, 2017 at 10:04:55PM +0200, Lars Schneider wrote: > I did run all tests under valgrind using "make valgrind" and I found > the following files with potential issues: > > cat valgrind.out | perl -nE 'say /^==.+\((.+)\:.+\)$/' | sort | uniq -c > 7102 >2 clone.c > 33

Re: cat-file timing window on Cygwin

On 27/08/17 12:33, Adam Dinwoodie wrote: > On Sun, Aug 27, 2017 at 03:06:31AM +0100, Ramsay Jones wrote: >> On 26/08/17 22:11, Adam Dinwoodie wrote: >>> On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote: Interesting. I find it a little hard to believe there's so obvious a bug

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

> On 27 Aug 2017, at 09:37, Martin Ågren wrote: > > The static-ness was silently dropped in commit 70428d1a5 ("pkt-line: add > packet_write_fmt_gently()", 2016-10-16). As a result, for each call to > packet_write_fmt_1, we allocate and leak a buffer. Oh :-( Thanks for

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

On Sun, Aug 27, 2017 at 09:37:32AM +0200, Martin Ågren wrote: > The static-ness was silently dropped in commit 70428d1a5 ("pkt-line: add > packet_write_fmt_gently()", 2016-10-16). As a result, for each call to > packet_write_fmt_1, we allocate and leak a buffer. > > We could keep the strbuf

Automatically delete branches containing accepted patches?

Hi, I have lots of git/git branches and once in a while some patches make it into git/git master. If this happens I would like to delete my branch with the patch automatically. That's not easily possible as the hashes on my branches are, of course, not the same as the hashes on git/git. How do

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

On Sun, Aug 27, 2017 at 11:41:52AM -0400, Jeff King wrote: > Ouch. So this means that git since v2.11 is basically leaking every > non-byte pack sent by upload-pack (so all of the ref advertisement and > want/have negotiation). Determined experimentally that the answer is: yes. The increase in

[PATCH] format-patch: use raw format for notes

If "--notes=..." is used with "git format-patch", the notes are prefixed with the ref's local name and indented, which looks odd and exposes the path of the ref. Extend the test that suppresses this behaviour so that it also catches this case, causing the notes to be included without additional

Re: [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1()

On 28 August 2017 at 01:23, Jeff King wrote: > On Sun, Aug 27, 2017 at 10:04:55PM +0200, Lars Schneider wrote: > >> I did run all tests under valgrind using "make valgrind" and I found >> the following files with potential issues: >> >> cat valgrind.out | perl -nE 'say